Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH] sim: rename bool argument to avoid stdbool clash
@ 2010-03-14 20:32 Mike Frysinger
  2010-03-15  0:32 ` Joel Brobecker
  0 siblings, 1 reply; 3+ messages in thread
From: Mike Frysinger @ 2010-03-14 20:32 UTC (permalink / raw)
  To: gdb-patches

Including stdbool.h before hw-properties.h results in a build error due
to the hw_add_boolean_property function having an argument named "bool"
in its prototype.  The source file has already be renamed to not use
this ("boolean" instead), so match the header to the source.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
2010-03-14  Mike Frysinger  <vapier@gentoo.org>

	* hw-properties.h (hw_add_boolean_property): Rename "bool" to
	"boolean".

 sim/common/hw-properties.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sim/common/hw-properties.h b/sim/common/hw-properties.h
index 61dbf77..7891cac 100644
--- a/sim/common/hw-properties.h
+++ b/sim/common/hw-properties.h
@@ -120,7 +120,7 @@ const struct hw_property *hw_find_array_property
 void hw_add_boolean_property
 (struct hw *me,
  const char *property,
- int bool);
+ int boolean);
 
 int hw_find_boolean_property
 (struct hw *me,
-- 
1.7.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] sim: rename bool argument to avoid stdbool clash
  2010-03-14 20:32 [PATCH] sim: rename bool argument to avoid stdbool clash Mike Frysinger
@ 2010-03-15  0:32 ` Joel Brobecker
  2010-03-15  7:09   ` Mike Frysinger
  0 siblings, 1 reply; 3+ messages in thread
From: Joel Brobecker @ 2010-03-15  0:32 UTC (permalink / raw)
  To: Mike Frysinger; +Cc: gdb-patches

> 2010-03-14  Mike Frysinger  <vapier@gentoo.org>
> 
> 	* hw-properties.h (hw_add_boolean_property): Rename "bool" to
> 	"boolean".

Thanks.  This is approved.

(note: I checked the function definition, to see if the parameter name
needed to be fixed there, but it's already fine).

-- 
Joel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] sim: rename bool argument to avoid stdbool clash
  2010-03-15  0:32 ` Joel Brobecker
@ 2010-03-15  7:09   ` Mike Frysinger
  0 siblings, 0 replies; 3+ messages in thread
From: Mike Frysinger @ 2010-03-15  7:09 UTC (permalink / raw)
  To: Joel Brobecker; +Cc: gdb-patches

[-- Attachment #1: Type: Text/Plain, Size: 473 bytes --]

On Sunday 14 March 2010 20:32:40 Joel Brobecker wrote:
> > 2010-03-14  Mike Frysinger  <vapier@gentoo.org>
> > 
> > 	* hw-properties.h (hw_add_boolean_property): Rename "bool" to
> > 	"boolean".
> 
> Thanks.  This is approved.
> 
> (note: I checked the function definition, to see if the parameter name
> needed to be fixed there, but it's already fine).

sorry, when i said "source files", i was referring to the function definitions 
in the .c files.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-03-15  7:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-03-14 20:32 [PATCH] sim: rename bool argument to avoid stdbool clash Mike Frysinger
2010-03-15  0:32 ` Joel Brobecker
2010-03-15  7:09   ` Mike Frysinger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox