From: Daniel Jacobowitz <dan@codesourcery.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org, vinschen@redhat.com, tromey@redhat.com
Subject: Re: Windows charset change
Date: Sun, 14 Mar 2010 22:40:00 -0000 [thread overview]
Message-ID: <20100314224016.GM9310@caradoc.them.org> (raw)
In-Reply-To: <83sk861vu4.fsf@gnu.org>
On Thu, Mar 11, 2010 at 09:50:43PM +0200, Eli Zaretskii wrote:
> > Date: Thu, 11 Mar 2010 13:18:01 -0500
> > From: Daniel Jacobowitz <dan@codesourcery.com>
> > Cc: Corinna Vinschen <vinschen@redhat.com>, Tom Tromey <tromey@redhat.com>
> >
> > The implicit declaration of GetACP is harder; I don't know what should
> > have been included to declare it. Looks like windows.h or winnls.h.
>
> It's windows.h, according to MSDN.
Thanks. I've checked this in.
--
Daniel Jacobowitz
CodeSourcery
2010-03-14 Daniel Jacobowitz <dan@codesourcery.com>
* charset.c [USE_WIN32API]: Include <windows.h>.
(_initialize_charset): Correct type of w32_host_default_charset.
Index: gdb/charset.c
===================================================================
RCS file: /cvs/src/src/gdb/charset.c,v
retrieving revision 1.29
diff -u -p -r1.29 charset.c
--- gdb/charset.c 5 Mar 2010 20:18:11 -0000 1.29
+++ gdb/charset.c 14 Mar 2010 22:36:05 -0000
@@ -33,6 +33,9 @@
#include "gdb_string.h"
#include <ctype.h>
+#ifdef USE_WIN32API
+#include <windows.h>
+#endif
\f
/* How GDB's character set support works
@@ -932,7 +935,7 @@ _initialize_charset (void)
auto_target_charset_name = auto_host_charset_name;
#elif defined (USE_WIN32API)
{
- static w32_host_default_charset[16]; /* "CP" + x<=5 digits + paranoia. */
+ static char w32_host_default_charset[16]; /* "CP" + x<=5 digits + paranoia. */
snprintf (w32_host_default_charset, sizeof w32_host_default_charset,
"CP%d", GetACP());
prev parent reply other threads:[~2010-03-14 22:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-11 18:18 Daniel Jacobowitz
2010-03-11 18:21 ` Tom Tromey
2010-03-11 19:51 ` Eli Zaretskii
2010-03-14 22:40 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100314224016.GM9310@caradoc.them.org \
--to=dan@codesourcery.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
--cc=vinschen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox