From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1323 invoked by alias); 14 Mar 2010 22:40:27 -0000 Received: (qmail 1311 invoked by uid 22791); 14 Mar 2010 22:40:26 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 14 Mar 2010 22:40:21 +0000 Received: (qmail 9195 invoked from network); 14 Mar 2010 22:40:20 -0000 Received: from unknown (HELO caradoc.them.org) (dan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 14 Mar 2010 22:40:20 -0000 Date: Sun, 14 Mar 2010 22:40:00 -0000 From: Daniel Jacobowitz To: Eli Zaretskii Cc: gdb-patches@sourceware.org, vinschen@redhat.com, tromey@redhat.com Subject: Re: Windows charset change Message-ID: <20100314224016.GM9310@caradoc.them.org> References: <20100311181801.GF9310@caradoc.them.org> <83sk861vu4.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83sk861vu4.fsf@gnu.org> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00509.txt.bz2 On Thu, Mar 11, 2010 at 09:50:43PM +0200, Eli Zaretskii wrote: > > Date: Thu, 11 Mar 2010 13:18:01 -0500 > > From: Daniel Jacobowitz > > Cc: Corinna Vinschen , Tom Tromey > > > > The implicit declaration of GetACP is harder; I don't know what should > > have been included to declare it. Looks like windows.h or winnls.h. > > It's windows.h, according to MSDN. Thanks. I've checked this in. -- Daniel Jacobowitz CodeSourcery 2010-03-14 Daniel Jacobowitz * charset.c [USE_WIN32API]: Include . (_initialize_charset): Correct type of w32_host_default_charset. Index: gdb/charset.c =================================================================== RCS file: /cvs/src/src/gdb/charset.c,v retrieving revision 1.29 diff -u -p -r1.29 charset.c --- gdb/charset.c 5 Mar 2010 20:18:11 -0000 1.29 +++ gdb/charset.c 14 Mar 2010 22:36:05 -0000 @@ -33,6 +33,9 @@ #include "gdb_string.h" #include +#ifdef USE_WIN32API +#include +#endif /* How GDB's character set support works @@ -932,7 +935,7 @@ _initialize_charset (void) auto_target_charset_name = auto_host_charset_name; #elif defined (USE_WIN32API) { - static w32_host_default_charset[16]; /* "CP" + x<=5 digits + paranoia. */ + static char w32_host_default_charset[16]; /* "CP" + x<=5 digits + paranoia. */ snprintf (w32_host_default_charset, sizeof w32_host_default_charset, "CP%d", GetACP());