From: Christopher Faylor <cgf-use-the-mailinglist-please@sourceware.org>
To: gdb-patches@sourceware.org,
Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>
Subject: Re: [RFC-v2] Reenable compilation with cygwin 1.5 versions
Date: Thu, 04 Mar 2010 16:38:00 -0000 [thread overview]
Message-ID: <20100304163838.GC12505@ednor.casa.cgf.cx> (raw)
In-Reply-To: <001901cabbaf$ebe7fa40$c3b7eec0$@muller@ics-cnrs.unistra.fr>
On Thu, Mar 04, 2010 at 04:32:38PM +0100, Pierre Muller wrote:
>This new version of the patch that
>tries to separate what is directly use of UNICODE versions
>of Windows API from what is Cygwin API specific code.
>
> Following Christopher's suggestion,
>the patch for remote-fileio.c defines a static
>cygwin_conv_path function, with the minimum need to
>the restricted usage made inside that file.
> __USE_OLD_CYGWIN_API_ macro could be renamed something like
>__PROVIDE_LOCAL_CYGWIN_CONV_PATH_...
> This patch can now be considered as independent of the
>windows-nat.c patch.
When I said to define something I really meant use #define. I was
hoping that most of the #ifdef __CYGWIN__ and __USE_OLD_CYGWIN_API stuff
could be encapsulated at the top of the file. I've taken a rough stab
at implementing what I meant and it does seem feasible but I don't have
the time to do much right now (to say nothing of being not-extremely-interested
in maintaining old Cygwin or MinGW versions).
I'll send my proof-of-concept along sometime today.
cgf
next prev parent reply other threads:[~2010-03-04 16:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-03 16:54 [RFC] " Pierre Muller
2010-03-03 17:14 ` Corinna Vinschen
2010-03-03 20:30 ` Christopher Faylor
2010-03-04 15:32 ` [RFC-v2] " Pierre Muller
2010-03-04 16:38 ` Christopher Faylor [this message]
2010-03-06 19:27 ` Christopher Faylor
2010-03-08 16:02 ` [RFA] " Pierre Muller
2010-03-08 22:11 ` Christopher Faylor
2010-03-08 23:15 ` Pierre Muller
2010-03-09 19:12 ` Christopher Faylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100304163838.GC12505@ednor.casa.cgf.cx \
--to=cgf-use-the-mailinglist-please@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=pierre.muller@ics-cnrs.unistra.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox