From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24196 invoked by alias); 4 Mar 2010 16:38:44 -0000 Received: (qmail 24183 invoked by uid 22791); 4 Mar 2010 16:38:44 -0000 X-Spam-Check-By: sourceware.org Received: from pool-98-110-186-187.bstnma.fios.verizon.net (HELO cgf.cx) (98.110.186.187) by sourceware.org (qpsmtpd/0.83/v0.83-20-g38e4449) with ESMTP; Thu, 04 Mar 2010 16:38:39 +0000 Received: from ednor.cgf.cx (ednor.casa.cgf.cx [192.168.187.5]) by cgf.cx (Postfix) with ESMTP id 3A8D713C0C8; Thu, 4 Mar 2010 11:38:38 -0500 (EST) Received: by ednor.cgf.cx (Postfix, from userid 201) id 374DF2B352; Thu, 4 Mar 2010 11:38:38 -0500 (EST) Date: Thu, 04 Mar 2010 16:38:00 -0000 From: Christopher Faylor To: gdb-patches@sourceware.org, Pierre Muller Subject: Re: [RFC-v2] Reenable compilation with cygwin 1.5 versions Message-ID: <20100304163838.GC12505@ednor.casa.cgf.cx> Mail-Followup-To: gdb-patches@sourceware.org, Pierre Muller References: <002701cabaf2$39739ad0$ac5ad070$@muller@ics-cnrs.unistra.fr> <20100303203012.GA31597@ednor.casa.cgf.cx> <001901cabbaf$ebe7fa40$c3b7eec0$@muller@ics-cnrs.unistra.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <001901cabbaf$ebe7fa40$c3b7eec0$@muller@ics-cnrs.unistra.fr> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00188.txt.bz2 On Thu, Mar 04, 2010 at 04:32:38PM +0100, Pierre Muller wrote: >This new version of the patch that >tries to separate what is directly use of UNICODE versions >of Windows API from what is Cygwin API specific code. > > Following Christopher's suggestion, >the patch for remote-fileio.c defines a static >cygwin_conv_path function, with the minimum need to >the restricted usage made inside that file. > __USE_OLD_CYGWIN_API_ macro could be renamed something like >__PROVIDE_LOCAL_CYGWIN_CONV_PATH_... > This patch can now be considered as independent of the >windows-nat.c patch. When I said to define something I really meant use #define. I was hoping that most of the #ifdef __CYGWIN__ and __USE_OLD_CYGWIN_API stuff could be encapsulated at the top of the file. I've taken a rough stab at implementing what I meant and it does seem feasible but I don't have the time to do much right now (to say nothing of being not-extremely-interested in maintaining old Cygwin or MinGW versions). I'll send my proof-of-concept along sometime today. cgf