From: Corinna Vinschen <vinschen@redhat.com>
To: gdb-patches@sourceware.org
Subject: [RFA] Makefile.in: Move mi-common.o from SUBDIR_MI_OBS to COMMON_OBS
Date: Sun, 28 Feb 2010 11:02:00 -0000 [thread overview]
Message-ID: <20100228110159.GA30573@calimero.vinschen.de> (raw)
Hi,
Today I tried to build GDB with the --disable-gdbmi option. The
link stage failed because infrun.c and breakpoint.c both call the
function async_reason_lookup, which is defined in mi-common.c.
Unfortunately, the mi-common.o object file is in the SUBDIR_MI_OBS files
which are not build if the --disable-gdbmi option is given.
The below patches fixes this problem be including mi-common.o into the
build unconditionally.
Ok to apply?
Thanks,
Corinna
* Makefile.in (SUBDIR_MI_OBS): Move mi-common.o from here...
(COMMON_OBS): ... to here since it's used unconditionally.
(SUBDIR_MI_SRCS): Move mi/mi-common.c from here...
(SFILES): To here.
Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.1113
diff -u -p -r1.1113 Makefile.in
--- Makefile.in 25 Feb 2010 20:30:58 -0000 1.1113
+++ Makefile.in 28 Feb 2010 11:01:41 -0000
@@ -202,14 +202,14 @@ SUBDIR_MI_OBS = \
mi-cmds.o mi-cmd-env.o mi-cmd-var.o mi-cmd-break.o mi-cmd-stack.o \
mi-cmd-file.o mi-cmd-disas.o mi-symbol-cmds.o mi-cmd-target.o \
mi-interp.o \
- mi-main.o mi-parse.o mi-getopt.o mi-common.o
+ mi-main.o mi-parse.o mi-getopt.o
SUBDIR_MI_SRCS = \
mi/mi-out.c mi/mi-console.c \
mi/mi-cmds.c mi/mi-cmd-env.c \
mi/mi-cmd-var.c mi/mi-cmd-break.c mi/mi-cmd-stack.c \
mi/mi-cmd-file.c mi/mi-cmd-disas.c mi/mi-symbol-cmds.c \
mi/mi-cmd-target.c mi/mi-interp.c \
- mi/mi-main.c mi/mi-parse.c mi/mi-getopt.c mi/mi-common.c
+ mi/mi-main.c mi/mi-parse.c mi/mi-getopt.c
SUBDIR_MI_DEPS =
SUBDIR_MI_LDFLAGS=
SUBDIR_MI_CFLAGS= \
@@ -669,6 +669,7 @@ SFILES = ada-exp.y ada-lang.c ada-typepr
m2-exp.y m2-lang.c m2-typeprint.c m2-valprint.c \
macrotab.c macroexp.c macrocmd.c macroscope.c main.c maint.c \
mdebugread.c memattr.c mem-break.c minsyms.c mipsread.c memory-map.c \
+ mi/mi-common.c \
objc-exp.y objc-lang.c \
objfiles.c osabi.c observer.c osdata.c \
p-exp.y p-lang.c p-typeprint.c p-valprint.c parse.c printcmd.c \
@@ -809,6 +810,7 @@ COMMON_OBS = $(DEPFILES) $(CONFIG_OBS) $
interps.o \
main.o \
macrotab.o macrocmd.o macroexp.o macroscope.o \
+ mi-common.o \
event-loop.o event-top.o inf-loop.o completer.o \
gdbarch.o arch-utils.o gdbtypes.o osabi.o copying.o \
memattr.o mem-break.o target.o parse.o language.o buildsym.o \
--
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat
next reply other threads:[~2010-02-28 11:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-28 11:02 Corinna Vinschen [this message]
2010-02-28 14:24 ` Daniel Jacobowitz
2010-02-28 15:04 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100228110159.GA30573@calimero.vinschen.de \
--to=vinschen@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox