From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9293 invoked by alias); 28 Feb 2010 11:02:10 -0000 Received: (qmail 9174 invoked by uid 22791); 28 Feb 2010 11:02:09 -0000 X-Spam-Check-By: sourceware.org Received: from aquarius.hirmke.de (HELO calimero.vinschen.de) (217.91.18.234) by sourceware.org (qpsmtpd/0.83/v0.83-20-g38e4449) with ESMTP; Sun, 28 Feb 2010 11:02:02 +0000 Received: by calimero.vinschen.de (Postfix, from userid 500) id 96A186D42F5; Sun, 28 Feb 2010 12:01:59 +0100 (CET) Date: Sun, 28 Feb 2010 11:02:00 -0000 From: Corinna Vinschen To: gdb-patches@sourceware.org Subject: [RFA] Makefile.in: Move mi-common.o from SUBDIR_MI_OBS to COMMON_OBS Message-ID: <20100228110159.GA30573@calimero.vinschen.de> Reply-To: gdb-patches@sourceware.org Mail-Followup-To: gdb-patches@sourceware.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00670.txt.bz2 Hi, Today I tried to build GDB with the --disable-gdbmi option. The link stage failed because infrun.c and breakpoint.c both call the function async_reason_lookup, which is defined in mi-common.c. Unfortunately, the mi-common.o object file is in the SUBDIR_MI_OBS files which are not build if the --disable-gdbmi option is given. The below patches fixes this problem be including mi-common.o into the build unconditionally. Ok to apply? Thanks, Corinna * Makefile.in (SUBDIR_MI_OBS): Move mi-common.o from here... (COMMON_OBS): ... to here since it's used unconditionally. (SUBDIR_MI_SRCS): Move mi/mi-common.c from here... (SFILES): To here. Index: Makefile.in =================================================================== RCS file: /cvs/src/src/gdb/Makefile.in,v retrieving revision 1.1113 diff -u -p -r1.1113 Makefile.in --- Makefile.in 25 Feb 2010 20:30:58 -0000 1.1113 +++ Makefile.in 28 Feb 2010 11:01:41 -0000 @@ -202,14 +202,14 @@ SUBDIR_MI_OBS = \ mi-cmds.o mi-cmd-env.o mi-cmd-var.o mi-cmd-break.o mi-cmd-stack.o \ mi-cmd-file.o mi-cmd-disas.o mi-symbol-cmds.o mi-cmd-target.o \ mi-interp.o \ - mi-main.o mi-parse.o mi-getopt.o mi-common.o + mi-main.o mi-parse.o mi-getopt.o SUBDIR_MI_SRCS = \ mi/mi-out.c mi/mi-console.c \ mi/mi-cmds.c mi/mi-cmd-env.c \ mi/mi-cmd-var.c mi/mi-cmd-break.c mi/mi-cmd-stack.c \ mi/mi-cmd-file.c mi/mi-cmd-disas.c mi/mi-symbol-cmds.c \ mi/mi-cmd-target.c mi/mi-interp.c \ - mi/mi-main.c mi/mi-parse.c mi/mi-getopt.c mi/mi-common.c + mi/mi-main.c mi/mi-parse.c mi/mi-getopt.c SUBDIR_MI_DEPS = SUBDIR_MI_LDFLAGS= SUBDIR_MI_CFLAGS= \ @@ -669,6 +669,7 @@ SFILES = ada-exp.y ada-lang.c ada-typepr m2-exp.y m2-lang.c m2-typeprint.c m2-valprint.c \ macrotab.c macroexp.c macrocmd.c macroscope.c main.c maint.c \ mdebugread.c memattr.c mem-break.c minsyms.c mipsread.c memory-map.c \ + mi/mi-common.c \ objc-exp.y objc-lang.c \ objfiles.c osabi.c observer.c osdata.c \ p-exp.y p-lang.c p-typeprint.c p-valprint.c parse.c printcmd.c \ @@ -809,6 +810,7 @@ COMMON_OBS = $(DEPFILES) $(CONFIG_OBS) $ interps.o \ main.o \ macrotab.o macrocmd.o macroexp.o macroscope.o \ + mi-common.o \ event-loop.o event-top.o inf-loop.o completer.o \ gdbarch.o arch-utils.o gdbtypes.o osabi.o copying.o \ memattr.o mem-break.o target.o parse.o language.o buildsym.o \ -- Corinna Vinschen Cygwin Project Co-Leader Red Hat