Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <dan@codesourcery.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] infcall: Remove gdb_assert ($sp overflow)
Date: Fri, 26 Feb 2010 22:53:00 -0000	[thread overview]
Message-ID: <20100226225249.GA15019@caradoc.them.org> (raw)
In-Reply-To: <20100219224805.GA9681@host0.dyn.jankratochvil.net>

On Fri, Feb 19, 2010 at 11:48:05PM +0100, Jan Kratochvil wrote:
> Unaware how inconvenient is an intentional crash of the testcase on some
> embedded/non-MMU systems.

Maybe limit it at least by nosignals?  It might still blow up uClinux
testing, I don't know offhand if there are other crashy tests.

> +foreach spval {0 -1} {
> +    set old_ldprefix $pf_prefix
> +    lappend pf_prefix "sp=$spval:"
> +
> +    gdb_test {set $old_sp = $sp}
> +    gdb_test "set \$sp = $spval"
> +
> +    gdb_test "call doubleit (1)"
> +
> +    gdb_test {set $sp = $old_sp}
> +    set pf_prefix $old_ldprefix
> +}

Because these tests run more than once, please give them unique names.

-- 
Daniel Jacobowitz
CodeSourcery


  parent reply	other threads:[~2010-02-26 22:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-19 22:48 Jan Kratochvil
2010-02-26 22:45 ` Tom Tromey
2010-02-27  1:19   ` [patch] infcall: Remove gdb_assert ($sp underflow) Jan Kratochvil
2010-02-28 10:53   ` [patch] infcall: Remove gdb_assert ($sp overflow) Joel Brobecker
2010-02-26 22:53 ` Daniel Jacobowitz [this message]
2010-02-27  0:46   ` [patch] infcall: Remove gdb_assert ($sp underflow) Jan Kratochvil
2010-02-28 14:35     ` Daniel Jacobowitz
2010-02-28 17:58       ` Jan Kratochvil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100226225249.GA15019@caradoc.them.org \
    --to=dan@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox