From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-70502-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 32583 invoked by alias); 26 Feb 2010 22:53:02 -0000
Received: (qmail 32569 invoked by uid 22791); 26 Feb 2010 22:53:01 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 26 Feb 2010 22:52:56 +0000
Received: (qmail 7221 invoked from network); 26 Feb 2010 22:52:55 -0000
Received: from unknown (HELO caradoc.them.org) (dan@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 26 Feb 2010 22:52:54 -0000
Date: Fri, 26 Feb 2010 22:53:00 -0000
From: Daniel Jacobowitz <dan@codesourcery.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] infcall: Remove gdb_assert ($sp overflow)
Message-ID: <20100226225249.GA15019@caradoc.them.org>
Mail-Followup-To: Jan Kratochvil <jan.kratochvil@redhat.com>, 	gdb-patches@sourceware.org
References: <20100219224805.GA9681@host0.dyn.jankratochvil.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20100219224805.GA9681@host0.dyn.jankratochvil.net>
User-Agent: Mutt/1.5.20 (2009-06-14)
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-02/txt/msg00661.txt.bz2

On Fri, Feb 19, 2010 at 11:48:05PM +0100, Jan Kratochvil wrote:
> Unaware how inconvenient is an intentional crash of the testcase on some
> embedded/non-MMU systems.

Maybe limit it at least by nosignals?  It might still blow up uClinux
testing, I don't know offhand if there are other crashy tests.

> +foreach spval {0 -1} {
> +    set old_ldprefix $pf_prefix
> +    lappend pf_prefix "sp=$spval:"
> +
> +    gdb_test {set $old_sp = $sp}
> +    gdb_test "set \$sp = $spval"
> +
> +    gdb_test "call doubleit (1)"
> +
> +    gdb_test {set $sp = $old_sp}
> +    set pf_prefix $old_ldprefix
> +}

Because these tests run more than once, please give them unique names.

-- 
Daniel Jacobowitz
CodeSourcery