Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Sami Wagiaalla <swagiaal@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [patch] Add support for imported declaration and correct search  order
Date: Thu, 25 Feb 2010 22:42:00 -0000	[thread overview]
Message-ID: <20100225224145.GA21231@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <4B86DA17.5040200@redhat.com>

On Thu, 25 Feb 2010 21:14:15 +0100, Sami Wagiaalla wrote:
>    retval->import_src = savestring (src, strlen(src));
>    retval->import_dest = savestring (dest, strlen(dest));
...
> +    retval->declaration = savestring (declaration, strlen (declaration));

(sure really only a nitpick)

These savestring calls can be simplified to:
# +    retval->declaration = xstrdup (declaration);

as was cleaned up by:
	[obv] Replace savestring by xstrdup where possible
	http://sourceware.org/ml/gdb-patches/2009-05/msg00516.html

but new `savestring (X, strlen (X))' calls apparently crept in since that time.


Thanks,
Jan


  parent reply	other threads:[~2010-02-25 22:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-25 20:17 Sami Wagiaalla
2010-02-25 21:50 ` Tom Tromey
2010-02-25 22:42 ` Jan Kratochvil [this message]
2010-02-26 20:11   ` Tom Tromey
2010-03-03 21:46     ` Sami Wagiaalla
2010-03-03 22:00       ` Tom Tromey
2010-03-08 16:39         ` Sami Wagiaalla
2010-03-08 18:58           ` Tom Tromey
2010-03-09 18:21             ` Sami Wagiaalla
2010-03-09 18:27               ` Tom Tromey
2010-03-23 20:31               ` Ulrich Weigand
2010-03-23 20:51                 ` Sami Wagiaalla
2010-03-23 21:35                   ` Ulrich Weigand
2010-03-29 14:48                     ` Sami Wagiaalla
2010-03-29 17:27                       ` Tom Tromey
2010-03-29 17:23                         ` Sami Wagiaalla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100225224145.GA21231@host0.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=swagiaal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox