From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-70483-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18882 invoked by alias); 25 Feb 2010 22:42:00 -0000
Received: (qmail 18850 invoked by uid 22791); 25 Feb 2010 22:41:58 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 25 Feb 2010 22:41:50 +0000
Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1PMfm6V017000 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) 	for <gdb-patches@sourceware.org>; Thu, 25 Feb 2010 17:41:48 -0500
Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o1PMfkMK003103 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); 	Thu, 25 Feb 2010 17:41:47 -0500
Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) 	by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id o1PMfjcF022352; 	Thu, 25 Feb 2010 23:41:45 +0100
Received: (from jkratoch@localhost) 	by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id o1PMfjfI022351; 	Thu, 25 Feb 2010 23:41:45 +0100
Date: Thu, 25 Feb 2010 22:42:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Sami Wagiaalla <swagiaal@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [patch] Add support for imported declaration and correct search  order
Message-ID: <20100225224145.GA21231@host0.dyn.jankratochvil.net>
References: <4B86DA17.5040200@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4B86DA17.5040200@redhat.com>
User-Agent: Mutt/1.5.20 (2009-08-17)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-02/txt/msg00642.txt.bz2

On Thu, 25 Feb 2010 21:14:15 +0100, Sami Wagiaalla wrote:
>    retval->import_src = savestring (src, strlen(src));
>    retval->import_dest = savestring (dest, strlen(dest));
...
> +    retval->declaration = savestring (declaration, strlen (declaration));

(sure really only a nitpick)

These savestring calls can be simplified to:
# +    retval->declaration = xstrdup (declaration);

as was cleaned up by:
	[obv] Replace savestring by xstrdup where possible
	http://sourceware.org/ml/gdb-patches/2009-05/msg00516.html

but new `savestring (X, strlen (X))' calls apparently crept in since that time.


Thanks,
Jan