From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: bauerman@br.ibm.com (Thiago Jung Bauermann)
Cc: brobecker@adacore.com (Joel Brobecker),
gdb-patches@sourceware.org,
luisgpm@linux.vnet.ibm.com (Luis Machado),
tyrlik@us.ibm.com (Matt Tyrlik)
Subject: Re: [PATCH 1/4] Support the new BookE ptrace interface
Date: Tue, 23 Feb 2010 19:07:00 -0000 [thread overview]
Message-ID: <201002231907.o1NJ7b8K004364@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <201002221827.04440.bauerman@br.ibm.com> from "Thiago Jung Bauermann" at Feb 22, 2010 06:27:04 PM
Thiago Jung Bauermann wrote:
> Good point. This version adds a have_ptrace_booke_interface function that
> is called whenever we need to check for support of the booke ptrace
> interface.
Thanks!
> This patch was approved before the 7.1 branch was created, but I didn't
> commit it then because the kernel support wasn't committed upstream yet.
> It is in the linux-next tree as of last friday, and will appear in 2.6.34.
> Can I commit this patch both for the 7.1 branch and HEAD?
Another problem just occurred to me, sorry for not noticing on the last
review: It seems the memory allocated in ppc_linux_new_thread is never
freed, or is it? Re-running the same inferior (with all different TID
values) would then leak a bit of memory ...
I guess this memory should be freed in a thread_exit notifier.
With this change, the patch would be OK for HEAD.
For the branch, Joel has the last word ...
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2010-02-23 19:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-24 0:31 Thiago Jung Bauermann
2009-12-29 6:12 ` Joel Brobecker
2009-12-30 19:51 ` Thiago Jung Bauermann
2010-01-04 17:33 ` Thiago Jung Bauermann
2010-01-05 4:51 ` Joel Brobecker
2010-01-15 17:41 ` Luis Machado
2010-01-16 3:09 ` Luis Machado
2010-01-18 4:16 ` Joel Brobecker
2010-02-11 17:06 ` Ulrich Weigand
2010-02-22 20:27 ` Thiago Jung Bauermann
2010-02-23 19:07 ` Ulrich Weigand [this message]
2010-02-23 23:42 ` Joel Brobecker
2010-02-25 18:16 ` Ulrich Weigand
2010-04-22 22:53 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201002231907.o1NJ7b8K004364@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=bauerman@br.ibm.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=luisgpm@linux.vnet.ibm.com \
--cc=tyrlik@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox