From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24377 invoked by alias); 23 Feb 2010 19:07:47 -0000 Received: (qmail 24360 invoked by uid 22791); 23 Feb 2010 19:07:46 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER X-Spam-Check-By: sourceware.org Received: from mtagate1.de.ibm.com (HELO mtagate1.de.ibm.com) (195.212.17.161) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 23 Feb 2010 19:07:42 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate1.de.ibm.com (8.13.1/8.13.1) with ESMTP id o1NJ7dRM021638 for ; Tue, 23 Feb 2010 19:07:39 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o1NJ7dpf1708216 for ; Tue, 23 Feb 2010 20:07:39 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id o1NJ7cQp004388 for ; Tue, 23 Feb 2010 20:07:39 +0100 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id o1NJ7b8K004364; Tue, 23 Feb 2010 20:07:37 +0100 Message-Id: <201002231907.o1NJ7b8K004364@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 23 Feb 2010 20:07:37 +0100 Subject: Re: [PATCH 1/4] Support the new BookE ptrace interface To: bauerman@br.ibm.com (Thiago Jung Bauermann) Date: Tue, 23 Feb 2010 19:07:00 -0000 From: "Ulrich Weigand" Cc: brobecker@adacore.com (Joel Brobecker), gdb-patches@sourceware.org, luisgpm@linux.vnet.ibm.com (Luis Machado), tyrlik@us.ibm.com (Matt Tyrlik) In-Reply-To: <201002221827.04440.bauerman@br.ibm.com> from "Thiago Jung Bauermann" at Feb 22, 2010 06:27:04 PM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00572.txt.bz2 Thiago Jung Bauermann wrote: > Good point. This version adds a have_ptrace_booke_interface function that > is called whenever we need to check for support of the booke ptrace > interface. Thanks! > This patch was approved before the 7.1 branch was created, but I didn't > commit it then because the kernel support wasn't committed upstream yet. > It is in the linux-next tree as of last friday, and will appear in 2.6.34. > Can I commit this patch both for the 7.1 branch and HEAD? Another problem just occurred to me, sorry for not noticing on the last review: It seems the memory allocated in ppc_linux_new_thread is never freed, or is it? Re-running the same inferior (with all different TID values) would then leak a bit of memory ... I guess this memory should be freed in a thread_exit notifier. With this change, the patch would be OK for HEAD. For the branch, Joel has the last word ... Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com