Re: [PATCH] Function-like cast notation support

["Sérgio Durigan Júnior" <sergiodj@redhat.com>]

On Wednesday 17 February 2010 16:47:29, Tom Tromey wrote:
> >>>>> "Sérgio" == Sérgio Durigan Júnior <sergiodj@redhat.com> writes:
> 
> Sérgio> The following patch adds support for function-like cast notation
> Sérgio> on GDB.
> 
> This looks good.
> 
> It could use a NEWS entry.  I suggest waiting until my NEWS change goes
> in, then adding it to the C++ improvements section.

Sounds fine by me.

> Sérgio> +		{ "void"      "void"		"'a'"		"void" }
> 
> I didn't realize this was supposed to work... learn something every day
> 
> :-)

Cool :-).

> For future reference, it is worth noting in the email how and whether
> you regression tested it.  I assume that everybody does this, but it is
> nice to be explicit about it.  At least in my case, this occasionally
> helps me realize that I forgot.

Oh darn, I knew I forgot something...  Sorry about that.  I tested it on the 
compile farm, using Tom's scripts.  Everything succeeded without regressions.

Regards,

-- 
Sérgio Durigan Júnior
Debugger Engineer -- Red Hat Inc.