From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32417 invoked by alias); 17 Feb 2010 19:02:07 -0000 Received: (qmail 32128 invoked by uid 22791); 17 Feb 2010 19:02:06 -0000 X-SWARE-Spam-Status: No, hits=-7.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 17 Feb 2010 19:02:02 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1HJ20rT000745 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 17 Feb 2010 14:02:01 -0500 Received: from miki.localnet (vpn-234-225.phx2.redhat.com [10.3.234.225]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o1HJ20FN023240; Wed, 17 Feb 2010 14:02:00 -0500 From: =?iso-8859-1?q?S=E9rgio_Durigan_J=FAnior?= To: tromey@redhat.com Subject: Re: [PATCH] Function-like cast notation support Date: Wed, 17 Feb 2010 19:02:00 -0000 User-Agent: KMail/1.12.4 (Linux/2.6.31.12-174.2.3.fc12.x86_64; KDE/4.3.5; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <201002171345.36988.sergiodj@redhat.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit Message-Id: <201002171701.59145.sergiodj@redhat.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00435.txt.bz2 On Wednesday 17 February 2010 16:47:29, Tom Tromey wrote: > >>>>> "Sérgio" == Sérgio Durigan Júnior writes: > > Sérgio> The following patch adds support for function-like cast notation > Sérgio> on GDB. > > This looks good. > > It could use a NEWS entry. I suggest waiting until my NEWS change goes > in, then adding it to the C++ improvements section. Sounds fine by me. > Sérgio> + { "void" "void" "'a'" "void" } > > I didn't realize this was supposed to work... learn something every day > > :-) Cool :-). > For future reference, it is worth noting in the email how and whether > you regression tested it. I assume that everybody does this, but it is > nice to be explicit about it. At least in my case, this occasionally > helps me realize that I forgot. Oh darn, I knew I forgot something... Sorry about that. I tested it on the compile farm, using Tom's scripts. Everything succeeded without regressions. Regards, -- Sérgio Durigan Júnior Debugger Engineer -- Red Hat Inc.