From: Daniel Jacobowitz <dan@codesourcery.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GDB <gdb-patches@sourceware.org>
Subject: Re: PATCH: Generate set_tdesc_osabi for valid OSABI
Date: Thu, 04 Feb 2010 17:06:00 -0000 [thread overview]
Message-ID: <20100204170603.GA19383@caradoc.them.org> (raw)
In-Reply-To: <6dc9ffc81002040854h6d88e085x4026d5a8320eeee7@mail.gmail.com>
On Thu, Feb 04, 2010 at 08:54:59AM -0800, H.J. Lu wrote:
> On Thu, Feb 4, 2010 at 8:04 AM, Daniel Jacobowitz <dan@codesourcery.com> wrote:
> > On Thu, Feb 04, 2010 at 07:49:10AM -0800, H.J. Lu wrote:
> >> 2010-02-04  H.J. Lu  <hongjiu.lu@intel.com>
> >>
> >> Â Â Â * target-descriptions.c (maint_print_c_tdesc_cmd): Generate
> >> Â Â Â set_tdesc_osabi for valid OSABI.
> >
> > This patch would require regenerating the board files after changing
> > the enum. Â If we have to hard-code the value, there should be a
> > warning to only add new items to the end of the enum unless
> > regenerating the files.
> >
>
> Good point. How about using OSABI string instead?
Nice trick. Yes, this is fine.
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2010-02-04 17:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 15:49 H.J. Lu
2010-02-04 16:04 ` Daniel Jacobowitz
2010-02-04 16:55 ` H.J. Lu
2010-02-04 17:06 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100204170603.GA19383@caradoc.them.org \
--to=dan@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox