From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-69960-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 978 invoked by alias); 4 Feb 2010 17:06:17 -0000
Received: (qmail 826 invoked by uid 22791); 4 Feb 2010 17:06:16 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 04 Feb 2010 17:06:11 +0000
Received: (qmail 365 invoked from network); 4 Feb 2010 17:06:10 -0000
Received: from unknown (HELO caradoc.them.org) (dan@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 4 Feb 2010 17:06:10 -0000
Date: Thu, 04 Feb 2010 17:06:00 -0000
From: Daniel Jacobowitz <dan@codesourcery.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GDB <gdb-patches@sourceware.org>
Subject: Re: PATCH: Generate set_tdesc_osabi for valid OSABI
Message-ID: <20100204170603.GA19383@caradoc.them.org>
Mail-Followup-To: "H.J. Lu" <hjl.tools@gmail.com>, 	GDB <gdb-patches@sourceware.org>
References: <20100204154910.GA2593@lucon.org>  <20100204160416.GB14962@caradoc.them.org>  <6dc9ffc81002040854h6d88e085x4026d5a8320eeee7@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <6dc9ffc81002040854h6d88e085x4026d5a8320eeee7@mail.gmail.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-02/txt/msg00119.txt.bz2

On Thu, Feb 04, 2010 at 08:54:59AM -0800, H.J. Lu wrote:
> On Thu, Feb 4, 2010 at 8:04 AM, Daniel Jacobowitz <dan@codesourcery.com> wrote:
> > On Thu, Feb 04, 2010 at 07:49:10AM -0800, H.J. Lu wrote:
> >> 2010-02-04  H.J. Lu  <hongjiu.lu@intel.com>
> >>
> >>       * target-descriptions.c (maint_print_c_tdesc_cmd): Generate
> >>       set_tdesc_osabi for valid OSABI.
> >
> > This patch would require regenerating the board files after changing
> > the enum.  If we have to hard-code the value, there should be a
> > warning to only add new items to the end of the enum unless
> > regenerating the files.
> >
> 
> Good point. How about using OSABI string instead?

Nice trick.  Yes, this is fine.

-- 
Daniel Jacobowitz
CodeSourcery