Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: jan.kratochvil@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Do not disappoint on "Create a core file of GDB?"
Date: Sun, 31 Jan 2010 14:13:00 -0000	[thread overview]
Message-ID: <201001311413.o0VEDJbY010431@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <20100130144723.GA9471@host0.dyn.jankratochvil.net> (message from 	Jan Kratochvil on Sat, 30 Jan 2010 15:47:23 +0100)

> Date: Sat, 30 Jan 2010 15:47:23 +0100
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> 
> On Sat, 30 Jan 2010 14:05:06 +0100, Mark Kettenis wrote:
> > I fear that after you did that the "NOTE: GDB has only three calls to
> > abort()." comment is no longer true.
> 
> There were four calls and there are three calls now.  The message has been
> updated:
> http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/utils.c.diff?cvsroot=src&r1=1.221&r2=1.222
> +  abort ();		/* NOTE: GDB has only three calls to abort().  */
> -	abort ();	/* NOTE: GDB has only four calls to abort().  */
> +	abort ();	/* NOTE: GDB has only three calls to abort().  */
> -          abort (); /* NOTE: GDB has only four calls to abort().  */
> +          abort (); /* NOTE: GDB has only three calls to abort().  */
> -	abort ();		/* NOTE: GDB has only four calls to abort().  */
> -	abort ();		/* NOTE: GDB has only four calls to abort().  */
> 
> and current HEAD:
> $ grep 'GDB has only.*abort' *
> utils.c:  abort ();		/* NOTE: GDB has only three calls to abort().  */
> utils.c:	abort ();	/* NOTE: GDB has only three calls to abort().  */
> utils.c:          abort (); /* NOTE: GDB has only three calls to abort().  */
> 
> The ChangeLog entry
> http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.11253&r2=1.11254
> describes thise "four"->"three" word change by:
> 	(internal_vproblem): Update the comment.
> which may have been insufficient, sorry.

Hmm, my diff-reading skills may have been affected by jetlag.  Sorry
for the noise!


  reply	other threads:[~2010-01-31 14:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-11 16:03 Jan Kratochvil
2010-01-11 16:06 ` Tristan Gingold
2010-01-11 16:18   ` Jan Kratochvil
2010-01-11 19:15   ` Eli Zaretskii
2010-01-12  8:44     ` Tristan Gingold
2010-01-12 19:37       ` Eli Zaretskii
2010-01-15  0:28         ` Jan Kratochvil
2010-01-15  8:24           ` Eli Zaretskii
2010-01-12 16:58 ` Tom Tromey
2010-01-15  0:35   ` Jan Kratochvil
2010-01-30 13:05     ` Mark Kettenis
2010-01-30 14:47       ` Jan Kratochvil
2010-01-31 14:13         ` Mark Kettenis [this message]
2010-03-31 13:38           ` Pierre Muller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201001311413.o0VEDJbY010431@glazunov.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox