From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-69839-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 27870 invoked by alias); 31 Jan 2010 14:13:47 -0000
Received: (qmail 27861 invoked by uid 22791); 31 Jan 2010 14:13:47 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 31 Jan 2010 14:13:41 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) 	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id o0VEDKcW031673; 	Sun, 31 Jan 2010 15:13:20 +0100 (CET)
Received: (from kettenis@localhost) 	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id o0VEDJbY010431; 	Sun, 31 Jan 2010 15:13:19 +0100 (CET)
Date: Sun, 31 Jan 2010 14:13:00 -0000
Message-Id: <201001311413.o0VEDJbY010431@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: jan.kratochvil@redhat.com
CC: gdb-patches@sourceware.org
In-reply-to: <20100130144723.GA9471@host0.dyn.jankratochvil.net> (message from 	Jan Kratochvil on Sat, 30 Jan 2010 15:47:23 +0100)
Subject: Re: [patch] Do not disappoint on "Create a core file of GDB?"
References: <20100111160241.GA12356@host0.dyn.jankratochvil.net>  <m31vhvnttj.fsf@fleche.redhat.com>  <20100115003529.GA26561@host0.dyn.jankratochvil.net>  <201001301305.o0UD56Zp003815@glazunov.sibelius.xs4all.nl> <20100130144723.GA9471@host0.dyn.jankratochvil.net>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-01/txt/msg00663.txt.bz2

> Date: Sat, 30 Jan 2010 15:47:23 +0100
> From: Jan Kratochvil <jan.kratochvil@redhat.com>
> 
> On Sat, 30 Jan 2010 14:05:06 +0100, Mark Kettenis wrote:
> > I fear that after you did that the "NOTE: GDB has only three calls to
> > abort()." comment is no longer true.
> 
> There were four calls and there are three calls now.  The message has been
> updated:
> http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/utils.c.diff?cvsroot=src&r1=1.221&r2=1.222
> +  abort ();		/* NOTE: GDB has only three calls to abort().  */
> -	abort ();	/* NOTE: GDB has only four calls to abort().  */
> +	abort ();	/* NOTE: GDB has only three calls to abort().  */
> -          abort (); /* NOTE: GDB has only four calls to abort().  */
> +          abort (); /* NOTE: GDB has only three calls to abort().  */
> -	abort ();		/* NOTE: GDB has only four calls to abort().  */
> -	abort ();		/* NOTE: GDB has only four calls to abort().  */
> 
> and current HEAD:
> $ grep 'GDB has only.*abort' *
> utils.c:  abort ();		/* NOTE: GDB has only three calls to abort().  */
> utils.c:	abort ();	/* NOTE: GDB has only three calls to abort().  */
> utils.c:          abort (); /* NOTE: GDB has only three calls to abort().  */
> 
> The ChangeLog entry
> http://sources.redhat.com/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.11253&r2=1.11254
> describes thise "four"->"three" word change by:
> 	(internal_vproblem): Update the comment.
> which may have been insufficient, sorry.

Hmm, my diff-reading skills may have been affected by jetlag.  Sorry
for the noise!