From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: Doug Evans <dje@google.com>,
gdb-patches ml <gdb-patches@sourceware.org>,
Tristan Gingold <gingold@adacore.com>,
Daniel Jacobowitz <dan@codesourcery.com>
Subject: Re: [RFA] Show some tips when file cmd get bfd_error_file_ambiguously_recognized
Date: Thu, 28 Jan 2010 21:56:00 -0000 [thread overview]
Message-ID: <20100128215609.GA31654@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <daef60381001270100w65b4fd08na227041c3e78c686@mail.gmail.com>
On Wed, 27 Jan 2010 10:00:34 +0100, Hui Zhu wrote:
> + ret_len = strlen (bfd_errmsg (error_tag)) + strlen (AMBIGUOUS_MESS1)
> + + 50 + strlen (AMBIGUOUS_MESS2);
> + ret = xmalloc (ret_len + 1);
Rather than all the C strings manipulation fragile magic maybe one could
afford mem_fileopen with ui_file_xstrdup (as being done sometimes in GDB).
Sure it may have been clear and not chosen as very ineffective.
Regards,
Jan
next prev parent reply other threads:[~2010-01-28 21:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-14 2:44 Hui Zhu
2010-01-14 10:15 ` Jan Kratochvil
2010-01-19 7:01 ` Hui Zhu
2010-01-19 7:57 ` Jan Kratochvil
2010-01-19 8:08 ` Hui Zhu
2010-01-26 8:01 ` Hui Zhu
2010-01-26 21:04 ` Doug Evans
2010-01-27 9:01 ` Hui Zhu
2010-01-28 18:18 ` Doug Evans
2010-01-28 21:56 ` Jan Kratochvil [this message]
2010-01-28 21:59 ` Doug Evans
2010-01-29 3:51 ` Joel Brobecker
2010-01-29 9:06 ` Hui Zhu
2010-02-04 7:09 ` Hui Zhu
2010-02-04 17:38 ` Doug Evans
2010-02-05 2:44 ` Hui Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100128215609.GA31654@host0.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=dan@codesourcery.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=gingold@adacore.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox