From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-69794-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14637 invoked by alias); 28 Jan 2010 21:56:47 -0000
Received: (qmail 14629 invoked by uid 22791); 28 Jan 2010 21:56:47 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 	tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 28 Jan 2010 21:56:42 +0000
Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0SLuCSS008428 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); 	Thu, 28 Jan 2010 16:56:13 -0500
Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o0SLuAXg021633 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); 	Thu, 28 Jan 2010 16:56:12 -0500
Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) 	by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id o0SLuASg031836; 	Thu, 28 Jan 2010 22:56:10 +0100
Received: (from jkratoch@localhost) 	by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id o0SLu97C031832; 	Thu, 28 Jan 2010 22:56:09 +0100
Date: Thu, 28 Jan 2010 21:56:00 -0000
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: Doug Evans <dje@google.com>, gdb-patches ml <gdb-patches@sourceware.org>,         Tristan Gingold <gingold@adacore.com>,         Daniel Jacobowitz <dan@codesourcery.com>
Subject: Re: [RFA] Show some tips when file cmd get  bfd_error_file_ambiguously_recognized
Message-ID: <20100128215609.GA31654@host0.dyn.jankratochvil.net>
References: <daef60381001131843u683d35d2nf937db926cea9740@mail.gmail.com>  <20100114101348.GA24756@host0.dyn.jankratochvil.net>  <daef60381001182301l6b0297c5pd43b56c64e8f277c@mail.gmail.com>  <20100119075642.GA30154@host0.dyn.jankratochvil.net>  <daef60381001190008x3e2964d2h6439db9293e3b3e6@mail.gmail.com>  <daef60381001260001j7dfb4c09jdace41e666a1b0a1@mail.gmail.com>  <e394668d1001261304o3c723d7apf18891c83da0eaf3@mail.gmail.com>  <daef60381001270100w65b4fd08na227041c3e78c686@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <daef60381001270100w65b4fd08na227041c3e78c686@mail.gmail.com>
User-Agent: Mutt/1.5.20 (2009-08-17)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-01/txt/msg00618.txt.bz2

On Wed, 27 Jan 2010 10:00:34 +0100, Hui Zhu wrote:
> +  ret_len = strlen (bfd_errmsg (error_tag)) + strlen (AMBIGUOUS_MESS1)
> +	    + 50 + strlen (AMBIGUOUS_MESS2);
> +  ret = xmalloc (ret_len + 1);

Rather than all the C strings manipulation fragile magic maybe one could
afford mem_fileopen with ui_file_xstrdup (as being done sometimes in GDB).

Sure it may have been clear and not chosen as very ineffective.


Regards,
Jan