From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org, Eli Zaretskii <eliz@gnu.org>
Cc: Kai Tietz <ktietz70@googlemail.com>
Subject: Re: [patch]: Fix build for GO32 and WIN32 targets
Date: Thu, 21 Jan 2010 21:24:00 -0000 [thread overview]
Message-ID: <201001212124.21679.pedro@codesourcery.com> (raw)
In-Reply-To: <837hrb72yh.fsf@gnu.org>
On Thursday 21 January 2010 18:00:38, Eli Zaretskii wrote:
> > Date: Thu, 21 Jan 2010 15:12:35 +0100
> > From: Kai Tietz <ktietz70@googlemail.com>
> >
> > Hello,
> >
> > the function check_syscall in file inflow.c is static, but isn't used
> > for GO32 and _WIN32 targets. So this leads to "defined but not used"
> > warning and breaks build. Patch fix this
>
> I don't understand. How come all other ports don't hit the same
> problem? AFAIK, this feature is not yet implemented on all of them.
> What am I missing?
Reading the code? ;-) All the callers of check_syscall are
wrapped inside:
#if !defined(__GO32__) && !defined(_WIN32)
The warning is now triggering because we've recently started
building gdb with -Wunused-function.
--
Pedro Alves
next prev parent reply other threads:[~2010-01-21 21:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 14:12 Kai Tietz
2010-01-21 14:15 ` Pedro Alves
2010-01-21 14:26 ` Kai Tietz
2010-01-21 18:00 ` Eli Zaretskii
2010-01-21 21:24 ` Pedro Alves [this message]
2010-01-21 22:05 ` Eli Zaretskii
2010-01-21 22:18 ` Pedro Alves
2010-01-22 7:36 ` Eli Zaretskii
2010-01-22 14:08 ` Pedro Alves
2010-01-22 17:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001212124.21679.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=ktietz70@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox