From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4321 invoked by alias); 21 Jan 2010 21:24:13 -0000 Received: (qmail 4312 invoked by uid 22791); 21 Jan 2010 21:24:13 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 21 Jan 2010 21:24:08 +0000 Received: (qmail 17522 invoked from network); 21 Jan 2010 21:24:06 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 21 Jan 2010 21:24:06 -0000 From: Pedro Alves To: gdb-patches@sourceware.org, Eli Zaretskii Subject: Re: [patch]: Fix build for GO32 and WIN32 targets Date: Thu, 21 Jan 2010 21:24:00 -0000 User-Agent: KMail/1.9.10 Cc: Kai Tietz References: <90baa01f1001210612v145db5f9m3b4607f602c2ae26@mail.gmail.com> <837hrb72yh.fsf@gnu.org> In-Reply-To: <837hrb72yh.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <201001212124.21679.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00536.txt.bz2 On Thursday 21 January 2010 18:00:38, Eli Zaretskii wrote: > > Date: Thu, 21 Jan 2010 15:12:35 +0100 > > From: Kai Tietz > > > > Hello, > > > > the function check_syscall in file inflow.c is static, but isn't used > > for GO32 and _WIN32 targets. So this leads to "defined but not used" > > warning and breaks build. Patch fix this > > I don't understand. How come all other ports don't hit the same > problem? AFAIK, this feature is not yet implemented on all of them. > What am I missing? Reading the code? ;-) All the callers of check_syscall are wrapped inside: #if !defined(__GO32__) && !defined(_WIN32) The warning is now triggering because we've recently started building gdb with -Wunused-function. -- Pedro Alves