From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [commit/Ada] Remove dead function (extract_string)...
Date: Tue, 12 Jan 2010 18:14:00 -0000 [thread overview]
Message-ID: <20100112181408.GP2007@adacore.com> (raw)
In-Reply-To: <m3bpgznvp7.fsf@fleche.redhat.com>
> Joel> I just noticed this unused function in ada-lang.c. It turns out I was
> Joel> supposed to have deleted it last year, but somehow I forgot.
>
> Adding -Wunused-function to the end of WARN_CFLAGS is interesting.
> I see more than a few unused functions -- and this is only looking at
> static functions.
I think we should indeed try to enable that warning. I assume it's
just a matter of adding it to
build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \
-Wformat-nonliteral -Wno-pointer-sign \
-Wno-unused -Wunused-value -Wno-switch -Wno-char-subscripts"
?
I'll give it a test tomorrow, and send a patch if all is OK.
--
Joel
next prev parent reply other threads:[~2010-01-12 18:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 8:56 Joel Brobecker
2010-01-12 16:19 ` Tom Tromey
2010-01-12 18:14 ` Joel Brobecker [this message]
2010-01-12 19:43 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100112181408.GP2007@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox