From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9392 invoked by alias); 12 Jan 2010 18:14:33 -0000 Received: (qmail 9384 invoked by uid 22791); 12 Jan 2010 18:14:32 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Jan 2010 18:14:26 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 7CE5A201DAF; Tue, 12 Jan 2010 13:14:24 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id hSgce+wHJpQP; Tue, 12 Jan 2010 13:14:24 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 0A87F201DC9; Tue, 12 Jan 2010 13:14:23 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id E4EC2F595E; Tue, 12 Jan 2010 22:14:08 +0400 (RET) Date: Tue, 12 Jan 2010 18:14:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [commit/Ada] Remove dead function (extract_string)... Message-ID: <20100112181408.GP2007@adacore.com> References: <20100112085541.GI11748@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00310.txt.bz2 > Joel> I just noticed this unused function in ada-lang.c. It turns out I was > Joel> supposed to have deleted it last year, but somehow I forgot. > > Adding -Wunused-function to the end of WARN_CFLAGS is interesting. > I see more than a few unused functions -- and this is only looking at > static functions. I think we should indeed try to enable that warning. I assume it's just a matter of adding it to build_warnings="-Wall -Wdeclaration-after-statement -Wpointer-arith \ -Wformat-nonliteral -Wno-pointer-sign \ -Wno-unused -Wunused-value -Wno-switch -Wno-char-subscripts" ? I'll give it a test tomorrow, and send a patch if all is OK. -- Joel