From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Daniel Gutson <dgutson@codesourcery.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gcore fix for native gdb on solaris
Date: Mon, 11 Jan 2010 16:28:00 -0000 [thread overview]
Message-ID: <20100111162807.GB13820@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <4AF9E5BD.3030900@codesourcery.com>
Hi Daniel,
On Tue, 10 Nov 2009 23:14:21 +0100, Daniel Gutson wrote:
> A define (_STRUCTURE_PROC) was needed before including procfs.h.
...
> 2009-11-10 Daniel Gutson <dgutson@codesourcery.com>
>
> bfd/
> * bfd.m4 (BFD_HAVE_SYS_PROCFS_TYPE): Define _STRUCTURE_PROC
> before including procfs.h.
...
> Index: bfd/bfd.m4
> ===================================================================
> RCS file: /cvs/src/src/bfd/bfd.m4,v
> retrieving revision 1.6
> diff -u -p -r1.6 bfd.m4
> --- bfd/bfd.m4 7 Sep 2009 09:15:27 -0000 1.6
> +++ bfd/bfd.m4 10 Nov 2009 22:06:31 -0000
> @@ -8,6 +8,8 @@ AC_DEFUN([BFD_HAVE_SYS_PROCFS_TYPE],
> AC_CACHE_VAL(bfd_cv_have_sys_procfs_type_$1,
> [AC_TRY_COMPILE([
> #define _SYSCALL32
> +/* Needed for new procfs interface on sparc-solaris. */
> +#define _STRUCTURED_PROC 1
> #include <sys/procfs.h>],
> [$1 avar],
> bfd_cv_have_sys_procfs_type_$1=yes,
> @@ -27,6 +29,8 @@ AC_DEFUN([BFD_HAVE_SYS_PROCFS_TYPE_MEMBE
> AC_CACHE_VAL(bfd_cv_have_sys_procfs_type_member_$1_$2,
> [AC_TRY_COMPILE([
> #define _SYSCALL32
> +/* Needed for new procfs interface on sparc-solaris. */
> +#define _STRUCTURED_PROC 1
> #include <sys/procfs.h>],
> [$1 avar; void* aref = (void*) &avar.$2],
> bfd_cv_have_sys_procfs_type_member_$1_$2=yes,
This change has caused the following change in generated gdb/configure which
is currently not checked in.
Assuming it is OK to update gdb/configure.
Regards,
Jan
--- a/gdb/configure
+++ b/gdb/configure
@@ -11897,6 +11898,8 @@ else
/* end confdefs.h. */
#define _SYSCALL32
+/* Needed for new procfs interface on sparc-solaris. */
+#define _STRUCTURED_PROC 1
#include <sys/procfs.h>
int
main ()
@@ -11932,6 +11935,8 @@ else
/* end confdefs.h. */
#define _SYSCALL32
+/* Needed for new procfs interface on sparc-solaris. */
+#define _STRUCTURED_PROC 1
#include <sys/procfs.h>
int
main ()
@@ -11967,6 +11972,8 @@ else
/* end confdefs.h. */
#define _SYSCALL32
+/* Needed for new procfs interface on sparc-solaris. */
+#define _STRUCTURED_PROC 1
#include <sys/procfs.h>
int
main ()
@@ -12002,6 +12009,8 @@ else
/* end confdefs.h. */
#define _SYSCALL32
+/* Needed for new procfs interface on sparc-solaris. */
+#define _STRUCTURED_PROC 1
#include <sys/procfs.h>
int
main ()
@@ -12037,6 +12046,8 @@ else
/* end confdefs.h. */
#define _SYSCALL32
+/* Needed for new procfs interface on sparc-solaris. */
+#define _STRUCTURED_PROC 1
#include <sys/procfs.h>
int
main ()
@@ -12072,6 +12083,8 @@ else
/* end confdefs.h. */
#define _SYSCALL32
+/* Needed for new procfs interface on sparc-solaris. */
+#define _STRUCTURED_PROC 1
#include <sys/procfs.h>
int
main ()
@@ -12107,6 +12120,8 @@ else
/* end confdefs.h. */
#define _SYSCALL32
+/* Needed for new procfs interface on sparc-solaris. */
+#define _STRUCTURED_PROC 1
#include <sys/procfs.h>
int
main ()
@@ -12142,6 +12157,8 @@ else
/* end confdefs.h. */
#define _SYSCALL32
+/* Needed for new procfs interface on sparc-solaris. */
+#define _STRUCTURED_PROC 1
#include <sys/procfs.h>
int
main ()
@@ -12177,6 +12194,8 @@ else
/* end confdefs.h. */
#define _SYSCALL32
+/* Needed for new procfs interface on sparc-solaris. */
+#define _STRUCTURED_PROC 1
#include <sys/procfs.h>
int
main ()
@@ -12212,6 +12231,8 @@ else
/* end confdefs.h. */
#define _SYSCALL32
+/* Needed for new procfs interface on sparc-solaris. */
+#define _STRUCTURED_PROC 1
#include <sys/procfs.h>
int
main ()
@@ -12247,6 +12268,8 @@ else
/* end confdefs.h. */
#define _SYSCALL32
+/* Needed for new procfs interface on sparc-solaris. */
+#define _STRUCTURED_PROC 1
#include <sys/procfs.h>
int
main ()
@@ -12282,6 +12305,8 @@ else
/* end confdefs.h. */
#define _SYSCALL32
+/* Needed for new procfs interface on sparc-solaris. */
+#define _STRUCTURED_PROC 1
#include <sys/procfs.h>
int
main ()
@@ -12317,6 +12342,8 @@ else
/* end confdefs.h. */
#define _SYSCALL32
+/* Needed for new procfs interface on sparc-solaris. */
+#define _STRUCTURED_PROC 1
#include <sys/procfs.h>
int
main ()
@@ -12352,6 +12379,8 @@ else
/* end confdefs.h. */
#define _SYSCALL32
+/* Needed for new procfs interface on sparc-solaris. */
+#define _STRUCTURED_PROC 1
#include <sys/procfs.h>
int
main ()
next prev parent reply other threads:[~2010-01-11 16:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-10 22:14 Daniel Gutson
2009-11-11 15:04 ` Tom Tromey
2010-01-05 0:52 ` Daniel Gutson
2010-01-05 17:51 ` Tom Tromey
2010-01-09 5:05 ` Joel Brobecker
2010-01-11 16:28 ` Jan Kratochvil [this message]
2010-01-12 3:39 ` Joel Brobecker
2010-01-12 12:27 ` Jan Kratochvil
2010-01-12 13:23 ` Joel Brobecker
2010-01-12 21:44 ` Daniel Gutson
2010-01-12 22:03 ` Jan Kratochvil
2010-01-12 23:57 ` Daniel Gutson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100111162807.GB13820@host0.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=dgutson@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox