From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32261 invoked by alias); 11 Jan 2010 16:28:30 -0000 Received: (qmail 32247 invoked by uid 22791); 11 Jan 2010 16:28:29 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 Jan 2010 16:28:23 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0BGSGrB014758 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 11 Jan 2010 11:28:16 -0500 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o0BGSAam009395 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 11 Jan 2010 11:28:15 -0500 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id o0BGS8VM014522; Mon, 11 Jan 2010 17:28:08 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id o0BGS7O5014518; Mon, 11 Jan 2010 17:28:07 +0100 Date: Mon, 11 Jan 2010 16:28:00 -0000 From: Jan Kratochvil To: Daniel Gutson Cc: "gdb-patches@sourceware.org" Subject: Re: [PATCH] gcore fix for native gdb on solaris Message-ID: <20100111162807.GB13820@host0.dyn.jankratochvil.net> References: <4AF9E5BD.3030900@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AF9E5BD.3030900@codesourcery.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00257.txt.bz2 Hi Daniel, On Tue, 10 Nov 2009 23:14:21 +0100, Daniel Gutson wrote: > A define (_STRUCTURE_PROC) was needed before including procfs.h. ... > 2009-11-10 Daniel Gutson > > bfd/ > * bfd.m4 (BFD_HAVE_SYS_PROCFS_TYPE): Define _STRUCTURE_PROC > before including procfs.h. ... > Index: bfd/bfd.m4 > =================================================================== > RCS file: /cvs/src/src/bfd/bfd.m4,v > retrieving revision 1.6 > diff -u -p -r1.6 bfd.m4 > --- bfd/bfd.m4 7 Sep 2009 09:15:27 -0000 1.6 > +++ bfd/bfd.m4 10 Nov 2009 22:06:31 -0000 > @@ -8,6 +8,8 @@ AC_DEFUN([BFD_HAVE_SYS_PROCFS_TYPE], > AC_CACHE_VAL(bfd_cv_have_sys_procfs_type_$1, > [AC_TRY_COMPILE([ > #define _SYSCALL32 > +/* Needed for new procfs interface on sparc-solaris. */ > +#define _STRUCTURED_PROC 1 > #include ], > [$1 avar], > bfd_cv_have_sys_procfs_type_$1=yes, > @@ -27,6 +29,8 @@ AC_DEFUN([BFD_HAVE_SYS_PROCFS_TYPE_MEMBE > AC_CACHE_VAL(bfd_cv_have_sys_procfs_type_member_$1_$2, > [AC_TRY_COMPILE([ > #define _SYSCALL32 > +/* Needed for new procfs interface on sparc-solaris. */ > +#define _STRUCTURED_PROC 1 > #include ], > [$1 avar; void* aref = (void*) &avar.$2], > bfd_cv_have_sys_procfs_type_member_$1_$2=yes, This change has caused the following change in generated gdb/configure which is currently not checked in. Assuming it is OK to update gdb/configure. Regards, Jan --- a/gdb/configure +++ b/gdb/configure @@ -11897,6 +11898,8 @@ else /* end confdefs.h. */ #define _SYSCALL32 +/* Needed for new procfs interface on sparc-solaris. */ +#define _STRUCTURED_PROC 1 #include int main () @@ -11932,6 +11935,8 @@ else /* end confdefs.h. */ #define _SYSCALL32 +/* Needed for new procfs interface on sparc-solaris. */ +#define _STRUCTURED_PROC 1 #include int main () @@ -11967,6 +11972,8 @@ else /* end confdefs.h. */ #define _SYSCALL32 +/* Needed for new procfs interface on sparc-solaris. */ +#define _STRUCTURED_PROC 1 #include int main () @@ -12002,6 +12009,8 @@ else /* end confdefs.h. */ #define _SYSCALL32 +/* Needed for new procfs interface on sparc-solaris. */ +#define _STRUCTURED_PROC 1 #include int main () @@ -12037,6 +12046,8 @@ else /* end confdefs.h. */ #define _SYSCALL32 +/* Needed for new procfs interface on sparc-solaris. */ +#define _STRUCTURED_PROC 1 #include int main () @@ -12072,6 +12083,8 @@ else /* end confdefs.h. */ #define _SYSCALL32 +/* Needed for new procfs interface on sparc-solaris. */ +#define _STRUCTURED_PROC 1 #include int main () @@ -12107,6 +12120,8 @@ else /* end confdefs.h. */ #define _SYSCALL32 +/* Needed for new procfs interface on sparc-solaris. */ +#define _STRUCTURED_PROC 1 #include int main () @@ -12142,6 +12157,8 @@ else /* end confdefs.h. */ #define _SYSCALL32 +/* Needed for new procfs interface on sparc-solaris. */ +#define _STRUCTURED_PROC 1 #include int main () @@ -12177,6 +12194,8 @@ else /* end confdefs.h. */ #define _SYSCALL32 +/* Needed for new procfs interface on sparc-solaris. */ +#define _STRUCTURED_PROC 1 #include int main () @@ -12212,6 +12231,8 @@ else /* end confdefs.h. */ #define _SYSCALL32 +/* Needed for new procfs interface on sparc-solaris. */ +#define _STRUCTURED_PROC 1 #include int main () @@ -12247,6 +12268,8 @@ else /* end confdefs.h. */ #define _SYSCALL32 +/* Needed for new procfs interface on sparc-solaris. */ +#define _STRUCTURED_PROC 1 #include int main () @@ -12282,6 +12305,8 @@ else /* end confdefs.h. */ #define _SYSCALL32 +/* Needed for new procfs interface on sparc-solaris. */ +#define _STRUCTURED_PROC 1 #include int main () @@ -12317,6 +12342,8 @@ else /* end confdefs.h. */ #define _SYSCALL32 +/* Needed for new procfs interface on sparc-solaris. */ +#define _STRUCTURED_PROC 1 #include int main () @@ -12352,6 +12379,8 @@ else /* end confdefs.h. */ #define _SYSCALL32 +/* Needed for new procfs interface on sparc-solaris. */ +#define _STRUCTURED_PROC 1 #include int main ()