Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>
Subject: Re: [patch] Fix false warning: Shared library is missing debugging  information.
Date: Mon, 11 Jan 2010 15:23:00 -0000	[thread overview]
Message-ID: <201001111523.46705.pedro@codesourcery.com> (raw)
In-Reply-To: <20100111151258.GA9354@host0.dyn.jankratochvil.net>

On Monday 11 January 2010 15:12:58, Jan Kratochvil wrote:

> So the case when debug info has been found - although in a separate debug info
> file - should be IMO the case "Yes" and not the case
> "Sorry-I've-tried-but-didn't-find-any".

Sounds right to me.

> +      /* We just check the state of any single separate debug info file, if
> +	 such one exists.  */
> +      objfile = so->objfile;
> +      if (objfile->separate_debug_objfile)
> +	objfile = objfile->separate_debug_objfile;
> +
>        if (! ui_out_is_mi_like_p (interp_ui_out (top_level_interpreter ()))
>  	  && so->symbols_loaded
> -	  && !objfile_has_partial_symbols (so->objfile)
> -	  && !objfile_has_full_symbols (so->objfile))
> +	  && !objfile_has_partial_symbols (objfile)
> +	  && !objfile_has_full_symbols (objfile))
>  	{
>  	  so_missing_debug_info = 1;
>  	  ui_out_field_string (uiout, "syms-read", "Yes (*)");
> 

separate_debug_objfile is now a list, so shouldn't you now look
over them all (main and all seperate objfiles) for symbols?

-- 
Pedro Alves


      parent reply	other threads:[~2010-01-11 15:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-11 15:13 Jan Kratochvil
2010-01-11 15:21 ` Tristan Gingold
2010-01-11 16:08   ` Jan Kratochvil
2010-01-11 16:14     ` Pedro Alves
2010-01-11 16:31       ` Jan Kratochvil
2010-01-11 18:08     ` Tom Tromey
2010-01-11 15:23 ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201001111523.46705.pedro@codesourcery.com \
    --to=pedro@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox