From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21759 invoked by alias); 11 Jan 2010 15:23:53 -0000 Received: (qmail 21742 invoked by uid 22791); 11 Jan 2010 15:23:52 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 Jan 2010 15:23:48 +0000 Received: (qmail 23602 invoked from network); 11 Jan 2010 15:23:46 -0000 Received: from unknown (HELO orlando) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 11 Jan 2010 15:23:46 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [patch] Fix false warning: Shared library is missing debugging information. Date: Mon, 11 Jan 2010 15:23:00 -0000 User-Agent: KMail/1.9.10 Cc: Jan Kratochvil References: <20100111151258.GA9354@host0.dyn.jankratochvil.net> In-Reply-To: <20100111151258.GA9354@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <201001111523.46705.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00250.txt.bz2 On Monday 11 January 2010 15:12:58, Jan Kratochvil wrote: > So the case when debug info has been found - although in a separate debug info > file - should be IMO the case "Yes" and not the case > "Sorry-I've-tried-but-didn't-find-any". Sounds right to me. > + /* We just check the state of any single separate debug info file, if > + such one exists. */ > + objfile = so->objfile; > + if (objfile->separate_debug_objfile) > + objfile = objfile->separate_debug_objfile; > + > if (! ui_out_is_mi_like_p (interp_ui_out (top_level_interpreter ())) > && so->symbols_loaded > - && !objfile_has_partial_symbols (so->objfile) > - && !objfile_has_full_symbols (so->objfile)) > + && !objfile_has_partial_symbols (objfile) > + && !objfile_has_full_symbols (objfile)) > { > so_missing_debug_info = 1; > ui_out_field_string (uiout, "syms-read", "Yes (*)"); > separate_debug_objfile is now a list, so shouldn't you now look over them all (main and all seperate objfiles) for symbols? -- Pedro Alves