From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Nick Roberts <nickrob@snap.net.nz>,
gdb@sourceware.org, gdb-patches@sourceware.org
Subject: Re: [patch] Fix crash on CLI indented comments [Re: [Bug:cli] Loading user-defined function generates an internal error]
Date: Fri, 01 Jan 2010 11:01:00 -0000 [thread overview]
Message-ID: <20100101110057.GA2988@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <20100101103520.GR2788@adacore.com>
On Fri, 01 Jan 2010 11:35:20 +0100, Joel Brobecker wrote:
> Approved. Thanks for fixing.
Checked-in.
> Test indented comment in file being sourced.
> * commands.exp: Test indented comment in file being sourced.
OK, thanks for this work.
Regards,
Jan
http://sourceware.org/ml/gdb-cvs/2010-01/msg00014.html
--- src/gdb/ChangeLog 2010/01/01 09:44:05 1.11190
+++ src/gdb/ChangeLog 2010/01/01 10:57:42 1.11191
@@ -1,3 +1,7 @@
+2010-01-01 Jan Kratochvil <jan.kratochvil@redhat.com>
+
+ * cli/cli-script.c (process_next_line): Check P2 overrun.
+
2009-01-01 Joel Brobecker <brobecker@adacore.com>
Update the copyright hearder to add year 2010 for most GDB files.
--- src/gdb/cli/cli-script.c 2010/01/01 07:31:47 1.55
+++ src/gdb/cli/cli-script.c 2010/01/01 10:57:43 1.56
@@ -893,7 +893,7 @@
p2 = p;
/* Strip leading whitespace. */
- while (*p2 == ' ' || *p2 == '\t')
+ while (p2 != p1 && (*p2 == ' ' || *p2 == '\t'))
p2++;
/* 'end' is always recognized, regardless of parse_commands value.
next prev parent reply other threads:[~2010-01-01 11:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <19258.59036.731093.439412@totara.tehura.co.nz>
[not found] ` <20091230054617.GA548@adacore.com>
[not found] ` <19259.54163.166299.854635@totara.tehura.co.nz>
2010-01-01 8:41 ` Jan Kratochvil
2010-01-01 10:36 ` Joel Brobecker
2010-01-01 11:01 ` Jan Kratochvil [this message]
2010-01-01 11:12 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100101110057.GA2988@host0.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=gdb@sourceware.org \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox