From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11962 invoked by alias); 1 Jan 2010 11:01:49 -0000 Received: (qmail 11769 invoked by uid 22791); 1 Jan 2010 11:01:48 -0000 X-SWARE-Spam-Status: No, hits=-0.9 required=5.0 tests=AWL,BAYES_00,FH_DATE_PAST_20XX,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 01 Jan 2010 11:01:43 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o01B10Rl028108 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 1 Jan 2010 06:01:00 -0500 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o01B0wc0010176 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 1 Jan 2010 06:01:00 -0500 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id o01B0wLF003044; Fri, 1 Jan 2010 12:00:58 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id o01B0vLu003043; Fri, 1 Jan 2010 12:00:57 +0100 Date: Fri, 01 Jan 2010 11:01:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: Nick Roberts , gdb@sourceware.org, gdb-patches@sourceware.org Subject: Re: [patch] Fix crash on CLI indented comments [Re: [Bug:cli] Loading user-defined function generates an internal error] Message-ID: <20100101110057.GA2988@host0.dyn.jankratochvil.net> References: <19258.59036.731093.439412@totara.tehura.co.nz> <20091230054617.GA548@adacore.com> <19259.54163.166299.854635@totara.tehura.co.nz> <20100101084028.GA29969@host0.dyn.jankratochvil.net> <20100101103520.GR2788@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100101103520.GR2788@adacore.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00016.txt.bz2 On Fri, 01 Jan 2010 11:35:20 +0100, Joel Brobecker wrote: > Approved. Thanks for fixing. Checked-in. > Test indented comment in file being sourced. > * commands.exp: Test indented comment in file being sourced. OK, thanks for this work. Regards, Jan http://sourceware.org/ml/gdb-cvs/2010-01/msg00014.html --- src/gdb/ChangeLog 2010/01/01 09:44:05 1.11190 +++ src/gdb/ChangeLog 2010/01/01 10:57:42 1.11191 @@ -1,3 +1,7 @@ +2010-01-01 Jan Kratochvil + + * cli/cli-script.c (process_next_line): Check P2 overrun. + 2009-01-01 Joel Brobecker Update the copyright hearder to add year 2010 for most GDB files. --- src/gdb/cli/cli-script.c 2010/01/01 07:31:47 1.55 +++ src/gdb/cli/cli-script.c 2010/01/01 10:57:43 1.56 @@ -893,7 +893,7 @@ p2 = p; /* Strip leading whitespace. */ - while (*p2 == ' ' || *p2 == '\t') + while (p2 != p1 && (*p2 == ' ' || *p2 == '\t')) p2++; /* 'end' is always recognized, regardless of parse_commands value.