Re: [patch] testsuite: false MI "unknown output after running" regression

[Jan Kratochvil <jan.kratochvil@redhat.com>]

On Fri, 01 Jan 2010 04:56:39 +0100, Joel Brobecker wrote:
> Phew, it took me a long time to understand how this patch could fix
> the bad regexp on some of the examples you provided (the after_stop
> field is empty), because I failed to notice that you added the missing
> comma.

Sorry I forgot to include the originally intended wdiff of this patch of mine.

	-re "\\*stopped,${r}${a}${bn}frame=\{addr=\"$hex\",func=\"$any\",args=\[\\\[\{\]$any\[\\\]\}\],file=\"$any\",fullname=\"${fullname_syntax}$any\",line=\"\[0-9\]*\"\}{+$after_stopped,+}thread-id=\"$decimal\",stopped-threads=$any\r\n$prompt_re" {


> This looks right to me. Please go ahead an apply (I will rotate the
> ChangeLog et al in a moment).

Checked-in already with 2010-01-01 (after an IRC approval).


Thanks,
Jan


http://sourceware.org/ml/gdb-cvs/2010-01/msg00010.html

--- src/gdb/testsuite/ChangeLog	2009/12/31 17:47:42	1.2060
+++ src/gdb/testsuite/ChangeLog	2010/01/01 07:57:56	1.2061
@@ -1,3 +1,8 @@
+2010-01-01  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+	* lib/mi-support.exp (mi_expect_stop <stopped at wrong place>): Insert
+	missing $after_stopped and comma (,) expectation.
+
 2009-12-31  Stan Shebs  <stan@codesourcery.com>
 
 	* gdb.trace/actions.exp: Test teval action.
--- src/gdb/testsuite/lib/mi-support.exp	2010/01/01 07:32:07	1.88
+++ src/gdb/testsuite/lib/mi-support.exp	2010/01/01 07:57:56	1.89
@@ -1038,7 +1038,7 @@
 	    pass "$test"
             return $expect_out(2,string)
 	}
-	-re "\\*stopped,${r}${a}${bn}frame=\{addr=\"$hex\",func=\"$any\",args=\[\\\[\{\]$any\[\\\]\}\],file=\"$any\",fullname=\"${fullname_syntax}$any\",line=\"\[0-9\]*\"\}thread-id=\"$decimal\",stopped-threads=$any\r\n$prompt_re" {
+	-re "\\*stopped,${r}${a}${bn}frame=\{addr=\"$hex\",func=\"$any\",args=\[\\\[\{\]$any\[\\\]\}\],file=\"$any\",fullname=\"${fullname_syntax}$any\",line=\"\[0-9\]*\"\}$after_stopped,thread-id=\"$decimal\",stopped-threads=$any\r\n$prompt_re" {
             verbose -log "got $expect_out(buffer)"
 	    fail "$test (stopped at wrong place)"
 	    return -1