From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24860 invoked by alias); 1 Jan 2010 08:02:40 -0000 Received: (qmail 24556 invoked by uid 22791); 1 Jan 2010 08:02:38 -0000 X-SWARE-Spam-Status: No, hits=-0.9 required=5.0 tests=AWL,BAYES_00,FH_DATE_PAST_20XX,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 01 Jan 2010 08:02:33 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o01829vU029679 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 1 Jan 2010 03:02:09 -0500 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o01826EJ002275 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 1 Jan 2010 03:02:09 -0500 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id o01826cV028835; Fri, 1 Jan 2010 09:02:06 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id o01825Pl028831; Fri, 1 Jan 2010 09:02:05 +0100 Date: Fri, 01 Jan 2010 08:02:00 -0000 From: Jan Kratochvil To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [patch] testsuite: false MI "unknown output after running" regression Message-ID: <20100101080205.GA28657@host0.dyn.jankratochvil.net> References: <20091231221942.GA4039@host0.dyn.jankratochvil.net> <20100101035639.GN2788@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100101035639.GN2788@adacore.com> User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00004.txt.bz2 On Fri, 01 Jan 2010 04:56:39 +0100, Joel Brobecker wrote: > Phew, it took me a long time to understand how this patch could fix > the bad regexp on some of the examples you provided (the after_stop > field is empty), because I failed to notice that you added the missing > comma. Sorry I forgot to include the originally intended wdiff of this patch of mine. -re "\\*stopped,${r}${a}${bn}frame=\{addr=\"$hex\",func=\"$any\",args=\[\\\[\{\]$any\[\\\]\}\],file=\"$any\",fullname=\"${fullname_syntax}$any\",line=\"\[0-9\]*\"\}{+$after_stopped,+}thread-id=\"$decimal\",stopped-threads=$any\r\n$prompt_re" { > This looks right to me. Please go ahead an apply (I will rotate the > ChangeLog et al in a moment). Checked-in already with 2010-01-01 (after an IRC approval). Thanks, Jan http://sourceware.org/ml/gdb-cvs/2010-01/msg00010.html --- src/gdb/testsuite/ChangeLog 2009/12/31 17:47:42 1.2060 +++ src/gdb/testsuite/ChangeLog 2010/01/01 07:57:56 1.2061 @@ -1,3 +1,8 @@ +2010-01-01 Jan Kratochvil + + * lib/mi-support.exp (mi_expect_stop ): Insert + missing $after_stopped and comma (,) expectation. + 2009-12-31 Stan Shebs * gdb.trace/actions.exp: Test teval action. --- src/gdb/testsuite/lib/mi-support.exp 2010/01/01 07:32:07 1.88 +++ src/gdb/testsuite/lib/mi-support.exp 2010/01/01 07:57:56 1.89 @@ -1038,7 +1038,7 @@ pass "$test" return $expect_out(2,string) } - -re "\\*stopped,${r}${a}${bn}frame=\{addr=\"$hex\",func=\"$any\",args=\[\\\[\{\]$any\[\\\]\}\],file=\"$any\",fullname=\"${fullname_syntax}$any\",line=\"\[0-9\]*\"\}thread-id=\"$decimal\",stopped-threads=$any\r\n$prompt_re" { + -re "\\*stopped,${r}${a}${bn}frame=\{addr=\"$hex\",func=\"$any\",args=\[\\\[\{\]$any\[\\\]\}\],file=\"$any\",fullname=\"${fullname_syntax}$any\",line=\"\[0-9\]*\"\}$after_stopped,thread-id=\"$decimal\",stopped-threads=$any\r\n$prompt_re" { verbose -log "got $expect_out(buffer)" fail "$test (stopped at wrong place)" return -1