From: Joel Brobecker <brobecker@adacore.com>
To: Michael <gdb-patches@cyberfiber.org>
Cc: gdb-patches@sourceware.org
Subject: Re: patch for testing purposes
Date: Fri, 01 Jan 2010 03:36:00 -0000 [thread overview]
Message-ID: <20100101033536.GM2788@adacore.com> (raw)
In-Reply-To: <4B3D20F7.6010203@cyberfiber.org>
> i accidentally reversed the source and destination source files,
> here it is again.
Ah, ok! :).
I am sorry if I am repeating the same things, but you forgot to use
-up when generating the patch... Have you also had the chance to
read the CONTRIBUTE file? The ChangeLog entry is still missing too.
A little word of introduction to explain what you are trying to do
and why would have been helpful as well.
> < /* Print the status word STATUS. */
> <
> < static void
> < print_i387_status_word (unsigned int status, struct ui_file *file)
> ---
> > // print the status word
> > // updated 20091231 (development@codenamezero.org)
We do not use C++-style comments in the GDB code, because GDB is
supposed to be buildable with non-GCC compilers supporting ISO C90.
Also, the the "updated 20091231 (development@codenamezero.org)" is
superfluous and should go.
> < fprintf_filtered (file, "Status Word: %s",
> < hex_string_custom (status, 4));
> < fputs_filtered (" ", file);
> < fprintf_filtered (file, " %s", (status & 0x0001) ? "IE" : " ");
It looks like you changed the indentation of the code. This is not
correct. The indentation used in C for GNU projects is 2 spaces.
The change of indentation causes a lot of changes which are not
really changes, and prevents me from easily spot what the real
changes are - if there are any, I couldn't spot them.
--
Joel
next prev parent reply other threads:[~2010-01-01 3:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-30 7:57 Michael
2009-12-30 8:14 ` Joel Brobecker
2009-12-30 10:21 ` Eli Zaretskii
[not found] ` <4B3B3AB1.5060106@cyberfiber.org>
[not found] ` <20091230114518.GD548@adacore.com>
2009-12-31 9:30 ` Michael
2009-12-31 11:38 ` Michael
2009-12-31 11:51 ` Joel Brobecker
2009-12-31 22:09 ` Michael
2010-01-01 3:36 ` Joel Brobecker [this message]
2010-01-01 7:14 ` Michael
2010-01-01 8:19 ` Joel Brobecker
[not found] ` <20091231114605.GK2788@adacore.com>
2009-12-31 11:56 ` Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100101033536.GM2788@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@cyberfiber.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox