From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5155 invoked by alias); 1 Jan 2010 03:36:15 -0000 Received: (qmail 5147 invoked by uid 22791); 1 Jan 2010 03:36:14 -0000 X-SWARE-Spam-Status: No, hits=-0.9 required=5.0 tests=AWL,BAYES_00,FH_DATE_PAST_20XX X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 01 Jan 2010 03:36:10 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 8C1E02BAB26; Thu, 31 Dec 2009 22:36:08 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id fDXDosZVzvwT; Thu, 31 Dec 2009 22:36:08 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 0ADA92BABAD; Thu, 31 Dec 2009 22:36:08 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id D7CE7F5937; Fri, 1 Jan 2010 04:35:36 +0100 (CET) Date: Fri, 01 Jan 2010 03:36:00 -0000 From: Joel Brobecker To: Michael Cc: gdb-patches@sourceware.org Subject: Re: patch for testing purposes Message-ID: <20100101033536.GM2788@adacore.com> References: <4B3B07F6.1020604@cyberfiber.org> <20091230081342.GD2788@adacore.com> <4B3B3AB1.5060106@cyberfiber.org> <20091230114518.GD548@adacore.com> <4B3C8D28.9070109@cyberfiber.org> <20091231115033.GL2788@adacore.com> <4B3D20F7.6010203@cyberfiber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B3D20F7.6010203@cyberfiber.org> User-Agent: Mutt/1.5.20 (2009-06-14) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00000.txt.bz2 > i accidentally reversed the source and destination source files, > here it is again. Ah, ok! :). I am sorry if I am repeating the same things, but you forgot to use -up when generating the patch... Have you also had the chance to read the CONTRIBUTE file? The ChangeLog entry is still missing too. A little word of introduction to explain what you are trying to do and why would have been helpful as well. > < /* Print the status word STATUS. */ > < > < static void > < print_i387_status_word (unsigned int status, struct ui_file *file) > --- > > // print the status word > > // updated 20091231 (development@codenamezero.org) We do not use C++-style comments in the GDB code, because GDB is supposed to be buildable with non-GCC compilers supporting ISO C90. Also, the the "updated 20091231 (development@codenamezero.org)" is superfluous and should go. > < fprintf_filtered (file, "Status Word: %s", > < hex_string_custom (status, 4)); > < fputs_filtered (" ", file); > < fprintf_filtered (file, " %s", (status & 0x0001) ? "IE" : " "); It looks like you changed the indentation of the code. This is not correct. The indentation used in C for GNU projects is 2 spaces. The change of indentation causes a lot of changes which are not really changes, and prevents me from easily spot what the real changes are - if there are any, I couldn't spot them. -- Joel