From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: brobecker@adacore.com, pedro@codesourcery.com, stan@codesourcery.com
Cc: gdb-patches@sourceware.org
Subject: Re: [commit] build failure in inf-ptrace.c (pa-hpux)
Date: Wed, 30 Dec 2009 20:10:00 -0000 [thread overview]
Message-ID: <200912302007.nBUK7Kc0001012@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <20091230194628.GH5942@adacore.com> (message from Joel Brobecker on Wed, 30 Dec 2009 23:46:28 +0400)
> Date: Wed, 30 Dec 2009 23:46:28 +0400
> From: Joel Brobecker <brobecker@adacore.com>
>
> Hello,
>
> inf-ptrace no longer builds on pa-hpux. Looks like a small thinko
> while updating gazillions of files the same way. I hope I fixed it
> right (notice the [...]->pspace = [...]->aspace on the second line
> I changed ;-). I didn't see I first fixed the name of the variable...
>
> 2009-12-30 Joel Brobecker <brobecker@adacore.com>
>
> Fix build failure in inf-ptrace.c.
> * inf-ptrace.c (inf_ptrace_follow_fork): Fix typo.
>
> Checked in.
For what it is worth, it also broke OpenBSD and I came up with the
same fix. I'm not sure the fix is right though.
> + child_inf->pspace = parent_inf->pspace;
> + child_inf->aspace = parent_inf->aspace;
Looking at the Linux code, this seesm to be right for vfork(), but the
code in inf-ptrace.c handles fork().
Pedro, Stan, what would be the right thing to do here?
next prev parent reply other threads:[~2009-12-30 20:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-30 19:47 Joel Brobecker
2009-12-30 20:10 ` Mark Kettenis [this message]
2009-12-31 8:50 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912302007.nBUK7Kc0001012@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
--cc=stan@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox