From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-69152-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 17406 invoked by alias); 30 Dec 2009 20:10:22 -0000
Received: (qmail 17396 invoked by uid 22791); 30 Dec 2009 20:10:22 -0000
X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 30 Dec 2009 20:10:17 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1]) 	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id nBUK7Mta030319; 	Wed, 30 Dec 2009 21:07:22 +0100 (CET)
Received: (from kettenis@localhost) 	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id nBUK7Kc0001012; 	Wed, 30 Dec 2009 21:07:20 +0100 (CET)
Date: Wed, 30 Dec 2009 20:10:00 -0000
Message-Id: <200912302007.nBUK7Kc0001012@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: brobecker@adacore.com, pedro@codesourcery.com, stan@codesourcery.com
CC: gdb-patches@sourceware.org
In-reply-to: <20091230194628.GH5942@adacore.com> (message from Joel Brobecker 	on Wed, 30 Dec 2009 23:46:28 +0400)
Subject: Re: [commit] build failure in inf-ptrace.c (pa-hpux)
References:  <20091230194628.GH5942@adacore.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-12/txt/msg00450.txt.bz2

> Date: Wed, 30 Dec 2009 23:46:28 +0400
> From: Joel Brobecker <brobecker@adacore.com>
> 
> Hello,
> 
> inf-ptrace no longer builds on pa-hpux. Looks like a small thinko
> while updating gazillions of files the same way. I hope I fixed it
> right (notice the [...]->pspace = [...]->aspace on the second line
> I changed ;-). I didn't see I first fixed the name of the variable...
> 
> 2009-12-30  Joel Brobecker  <brobecker@adacore.com>
> 
>         Fix build failure in inf-ptrace.c.
>         * inf-ptrace.c (inf_ptrace_follow_fork): Fix typo.
> 
> Checked in.

For what it is worth, it also broke OpenBSD and I came up with the
same fix.  I'm not sure the fix is right though.

> +      child_inf->pspace = parent_inf->pspace;
> +      child_inf->aspace = parent_inf->aspace;

Looking at the Linux code, this seesm to be right for vfork(), but the
code in inf-ptrace.c handles fork().

Pedro, Stan, what would be the right thing to do here?