Re: [patch] Fix breakpoints in unloaded shared libraries

[Jan Kratochvil <jan.kratochvil@redhat.com>]

On Tue, 22 Dec 2009 20:46:59 +0100, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> 
> Jan> Do I understand it correctly your approval is for the gdb/ part while the
> Jan> gdb/testsuite/ part is still left pending for review some other day?
> 
> Sorry, I meant to approve it all, I just didn't quote the second part.
> I'll be more clear in the future.

Regression retested on {x86_64,x86_64-m32,i686}-fedora12-linux-gnu and
checked-in both parts:

http://sourceware.org/ml/gdb-cvs/2009-12/msg00121.html

gdb/
	* breakpoint.c (bpstat_stop_status): Check BL->SHLIB_DISABLED.
	(print_breakpoint_location): New comment.  Check LOC->SHLIB_DISABLED.
	Check LOC validity before printing it.  Use LOC instead of B->LOC.
	Swap the if conditionals order.
	
gdb/testsuite/
	* gdb.base/unload.c (main): Change the UNLOADSHR parameter to 1.
	Replace the printf call of Y by provided "y-set-1" label.  New block
	for the second shared library.
	* gdb.base/unload.exp: Compile also the second library, call
	gdb_load_shlibs also for it.  Use now gdb_breakpoint.
	(single pending breakpoint info): Rename to ...
	(pending breakpoint info before run): ... this extended test.
	(libfile2, libname2, libsrcfile2, libsrc2)
	(lib_sl2): New variables.
	(exec_opts): Set also SHLIB_NAME2.
	(pending breakpoint info on first run at shrfunc1)
	(pending breakpoint info on second run at shrfunc1)
	(pending breakpoint info on second run at shrfunc2)
	(print y from libfile, print y from libfile2): New tests.
	* gdb.base/unloadshr.c (shrfunc1): Change the returned value.
	* gdb.base/unloadshr2.c: New.


Thanks,
Jan