From: Vladimir Prus <vladimir@codesourcery.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: RFA: unbreak typedefed bitfield
Date: Mon, 21 Dec 2009 17:18:00 -0000 [thread overview]
Message-ID: <200912212018.33780.vladimir@codesourcery.com> (raw)
In-Reply-To: <20091221171500.GA16198@caradoc.them.org>
On Monday 21 December 2009 20:15:00 Daniel Jacobowitz wrote:
> On Mon, Dec 21, 2009 at 10:08:38AM -0700, Tom Tromey wrote:
> > You could try:
> >
> > #define TYPE_LENGTH(thistype) check_typedef (thistype)->length
> >
> > While this is probably insufficient to fix the check_typedef problem in
> > general, it may help with the most common source of problems.
>
> TYPE_LENGTH (type) = DW_UNSND (attr);
>
> That's likely to cause some trouble.
IMO, this usage should just go, in preference to
type_set_length (type, DW_UNSND (attr));
In fact, I think TYPE_LENGTH itself should go -- there's no reason to use a macro
with all the nasty behaviours like above when inline functions would work just fine.
- Volodya
next prev parent reply other threads:[~2009-12-21 17:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-18 12:41 Vladimir Prus
2009-12-18 13:06 ` Joel Brobecker
2009-12-18 14:17 ` Daniel Jacobowitz
2009-12-18 14:20 ` Vladimir Prus
2009-12-18 14:24 ` Daniel Jacobowitz
2009-12-21 9:51 ` Vladimir Prus
2009-12-21 13:23 ` Joel Brobecker
2009-12-18 19:55 ` Tom Tromey
2009-12-21 10:00 ` Vladimir Prus
2009-12-21 17:08 ` Tom Tromey
2009-12-21 17:15 ` Daniel Jacobowitz
2009-12-21 17:18 ` Vladimir Prus [this message]
2009-12-21 17:37 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912212018.33780.vladimir@codesourcery.com \
--to=vladimir@codesourcery.com \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox