From: Daniel Jacobowitz <drow@false.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Vladimir Prus <vladimir@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: RFA: unbreak typedefed bitfield
Date: Fri, 18 Dec 2009 14:17:00 -0000 [thread overview]
Message-ID: <20091218141740.GA18065@caradoc.them.org> (raw)
In-Reply-To: <20091218130612.GD2788@adacore.com>
On Fri, Dec 18, 2009 at 05:06:12PM +0400, Joel Brobecker wrote:
> > --- a/gdb/value.c
> > +++ b/gdb/value.c
> > @@ -1873,6 +1873,7 @@ value_primitive_field (struct value *arg1, int offset,
> >
> > CHECK_TYPEDEF (arg_type);
> > type = TYPE_FIELD_TYPE (arg_type, fieldno);
> > + check_typedef (type);
> >
> > /* Handle packed fields */
>
> Looks OK to me (you forgot the ChangeLog entry, btw).
What does this do? CHECK_TYPEDEF side-effects its argument;
check_typedef will leave its argument as a TYPE_CODE_TYPEDEF. I think
it fills in some other fields in the typedef, is that what matters
here?
It's unusual to see check_typedef without an assignment.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2009-12-18 14:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-18 12:41 Vladimir Prus
2009-12-18 13:06 ` Joel Brobecker
2009-12-18 14:17 ` Daniel Jacobowitz [this message]
2009-12-18 14:20 ` Vladimir Prus
2009-12-18 14:24 ` Daniel Jacobowitz
2009-12-21 9:51 ` Vladimir Prus
2009-12-21 13:23 ` Joel Brobecker
2009-12-18 19:55 ` Tom Tromey
2009-12-21 10:00 ` Vladimir Prus
2009-12-21 17:08 ` Tom Tromey
2009-12-21 17:15 ` Daniel Jacobowitz
2009-12-21 17:18 ` Vladimir Prus
2009-12-21 17:37 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091218141740.GA18065@caradoc.them.org \
--to=drow@false.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=vladimir@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox