From: Vladimir Prus <vladimir@codesourcery.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: Jakob Engblom <jakob@virtutech.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: GDB MI Reverse Commands added [3 of 3]
Date: Wed, 16 Dec 2009 08:06:00 -0000 [thread overview]
Message-ID: <200912161106.12861.vladimir@codesourcery.com> (raw)
In-Reply-To: <4B27E619.8080607@vmware.com>
On Tuesday 15 December 2009 22:40:09 Michael Snyder wrote:
> Jakob Engblom wrote:
> > Final part: the test suite for gdb-MI reverse debugging commands. Attached as a
> > file, to be put in [gdb]/src/gdb/testsuite/gdb.mi/
> >
> > Best regards,
> >
> > /jakob
>
> Part 3, test suite.
I do not have any further comments relative to those in:
http://article.gmane.org/gmane.comp.gdb.patches/51523/
It does not seem like any of them were addressed. When they are addressed,
this patch is OK. Because the only non-mechanical change is replacement of
FIXME with a suitable comment, and reverse-mode experts are in much better
position to decide if a comment captures the behaviour properly, I don't
think I have to re-review any revision of this patch -- please commit directly
when you think it's ready.
- Volodya
next prev parent reply other threads:[~2009-12-16 8:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-26 15:10 Jakob Engblom
2009-08-27 1:43 ` Michael Snyder
2009-08-31 13:13 ` Jakob Engblom
2009-09-01 12:48 ` Jakob Engblom
2009-09-01 17:36 ` Tom Tromey
2009-09-07 1:18 ` Michael Snyder
2009-09-07 7:10 ` Jakob Engblom
2009-09-07 18:09 ` Joel Brobecker
2009-09-08 7:11 ` Jakob Engblom
2009-09-02 8:23 ` Vladimir Prus
2009-09-03 18:44 ` Jakob Engblom
2009-09-03 20:13 ` Michael Snyder
2009-09-07 1:44 ` Hui Zhu
2009-12-15 19:43 ` Michael Snyder
2009-12-16 9:59 ` Vladimir Prus
2009-12-15 19:42 ` Michael Snyder
2009-12-16 8:06 ` Vladimir Prus [this message]
2009-12-16 8:48 ` Jakob Engblom
2009-12-16 10:05 ` Vladimir Prus
2010-02-12 21:39 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912161106.12861.vladimir@codesourcery.com \
--to=vladimir@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=jakob@virtutech.com \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox