From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18578 invoked by alias); 16 Dec 2009 08:06:21 -0000 Received: (qmail 18570 invoked by uid 22791); 16 Dec 2009 08:06:21 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 16 Dec 2009 08:06:16 +0000 Received: (qmail 13469 invoked from network); 16 Dec 2009 08:06:14 -0000 Received: from unknown (HELO wind.localnet) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 16 Dec 2009 08:06:14 -0000 From: Vladimir Prus To: Michael Snyder Subject: Re: GDB MI Reverse Commands added [3 of 3] Date: Wed, 16 Dec 2009 08:06:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.31-14-generic-pae; KDE/4.3.2; i686; ; ) Cc: Jakob Engblom , "gdb-patches@sourceware.org" References: <00d001ca265a$ddd0c800$99725800$@com> <4B27E619.8080607@vmware.com> In-Reply-To: <4B27E619.8080607@vmware.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <200912161106.12861.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00204.txt.bz2 On Tuesday 15 December 2009 22:40:09 Michael Snyder wrote: > Jakob Engblom wrote: > > Final part: the test suite for gdb-MI reverse debugging commands. Attached as a > > file, to be put in [gdb]/src/gdb/testsuite/gdb.mi/ > > > > Best regards, > > > > /jakob > > Part 3, test suite. I do not have any further comments relative to those in: http://article.gmane.org/gmane.comp.gdb.patches/51523/ It does not seem like any of them were addressed. When they are addressed, this patch is OK. Because the only non-mechanical change is replacement of FIXME with a suitable comment, and reverse-mode experts are in much better position to decide if a comment captures the behaviour properly, I don't think I have to re-review any revision of this patch -- please commit directly when you think it's ready. - Volodya