Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [patch] testsuite: bigcore.exp fuzzy PASS message fix
@ 2009-11-29 15:12 Jan Kratochvil
  2009-11-30 20:25 ` Tom Tromey
  2009-12-21  5:49 ` Joel Brobecker
  0 siblings, 2 replies; 4+ messages in thread
From: Jan Kratochvil @ 2009-11-29 15:12 UTC (permalink / raw)
  To: gdb-patches

Hi,

seen needlessly fuzzy results:
	-PASS: gdb.base/bigcore.exp: extract next heap (stop at 50)
	-PASS: gdb.base/bigcore.exp: extract prev heap (stop at 50)
	+PASS: gdb.base/bigcore.exp: extract next heap
	+PASS: gdb.base/bigcore.exp: extract prev heap

but the .exp file just is not patient enough:
	-Total of 4292375328 (0xffd87320) bytes bytes 53 chunks
	+Total of 4292422432 (0xffd92b20) bytes bytes 41 chunks

Increased to 200.  Tested on {x86_64,x86_64-m32}-fedora12-linux-gnu.


Thanks,
Jan


gdb/testsuite/
2009-11-29  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* gdb.base/bigcore.exp (extract_heap): Set $lim limit to 200.

--- a/gdb/testsuite/gdb.base/bigcore.exp
+++ b/gdb/testsuite/gdb.base/bigcore.exp
@@ -96,7 +96,7 @@ proc extract_heap { dir } {
 	}
 	-re " = \\(struct list \\*\\) (0x\[0-9a-f\]*).*$gdb_prompt $" {
 	    set heap [concat $heap $expect_out(1,string)]
-	    if { $lim >= 50 } {
+	    if { $lim >= 200 } {
 		pass "$test (stop at $lim)"
 	    } else {
 		incr lim


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [patch] testsuite: bigcore.exp fuzzy PASS message fix
  2009-11-29 15:12 [patch] testsuite: bigcore.exp fuzzy PASS message fix Jan Kratochvil
@ 2009-11-30 20:25 ` Tom Tromey
  2009-11-30 22:58   ` Jan Kratochvil
  2009-12-21  5:49 ` Joel Brobecker
  1 sibling, 1 reply; 4+ messages in thread
From: Tom Tromey @ 2009-11-30 20:25 UTC (permalink / raw)
  To: Jan Kratochvil; +Cc: gdb-patches

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> gdb/testsuite/
Jan> 2009-11-29  Jan Kratochvil  <jan.kratochvil@redhat.com>
Jan> 	* gdb.base/bigcore.exp (extract_heap): Set $lim limit to 200.

Ok.

Tom


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [patch] testsuite: bigcore.exp fuzzy PASS message fix
  2009-11-30 20:25 ` Tom Tromey
@ 2009-11-30 22:58   ` Jan Kratochvil
  0 siblings, 0 replies; 4+ messages in thread
From: Jan Kratochvil @ 2009-11-30 22:58 UTC (permalink / raw)
  To: Tom Tromey; +Cc: gdb-patches

On Mon, 30 Nov 2009 21:24:55 +0100, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> 
> Jan> gdb/testsuite/
> Jan> 2009-11-29  Jan Kratochvil  <jan.kratochvil@redhat.com>
> Jan> 	* gdb.base/bigcore.exp (extract_heap): Set $lim limit to 200.
> 
> Ok.

Checked-in:
	http://sourceware.org/ml/gdb-cvs/2009-11/msg00233.html


Thanks,
Jan


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [patch] testsuite: bigcore.exp fuzzy PASS message fix
  2009-11-29 15:12 [patch] testsuite: bigcore.exp fuzzy PASS message fix Jan Kratochvil
  2009-11-30 20:25 ` Tom Tromey
@ 2009-12-21  5:49 ` Joel Brobecker
  1 sibling, 0 replies; 4+ messages in thread
From: Joel Brobecker @ 2009-12-21  5:49 UTC (permalink / raw)
  To: Jan Kratochvil; +Cc: gdb-patches

> gdb/testsuite/
> 2009-11-29  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	* gdb.base/bigcore.exp (extract_heap): Set $lim limit to 200.

FYI: checked in the gdb-7.0 branch.

-- 
Joel


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-12-21  5:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-29 15:12 [patch] testsuite: bigcore.exp fuzzy PASS message fix Jan Kratochvil
2009-11-30 20:25 ` Tom Tromey
2009-11-30 22:58   ` Jan Kratochvil
2009-12-21  5:49 ` Joel Brobecker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox