Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Vladimir Prus <vladimir@codesourcery.com>
To: Joel Brobecker <brobecker@adacore.com>,  gdb-patches@sources.redhat.com
Subject: Re: Fix async mode with remote targets
Date: Sat, 28 Nov 2009 17:40:00 -0000	[thread overview]
Message-ID: <200911282040.00504.vladimir@codesourcery.com> (raw)
In-Reply-To: <20091128172915.GG18125@adacore.com>

[-- Attachment #1: Type: Text/Plain, Size: 114 bytes --]

On Saturday 28 November 2009 20:29:15 Joel Brobecker wrote:

> ENOPATCH :)
> 
> 

Sorry, here it goes.

- Volodya

[-- Attachment #2: final.diff --]
[-- Type: text/x-patch, Size: 1369 bytes --]

Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.11117
diff -u -p -r1.11117 ChangeLog
--- ChangeLog	27 Nov 2009 16:11:56 -0000	1.11117
+++ ChangeLog	28 Nov 2009 16:57:39 -0000
@@ -1,3 +1,8 @@
+2009-11-28  Vladimir Prus  <vladimir@codesourcery.com>
+
+	* target.c (target_terminal_inferior): Use target_can_async_p, not
+	target_is_async_p.
+
 2009-11-27  Ulrich Weigand  <uweigand@de.ibm.com>
 
 	* s390-nat.c (s390_can_use_hw_breakpoint): Only support breakpoints
Index: target.c
===================================================================
RCS file: /cvs/src/src/gdb/target.c,v
retrieving revision 1.233
diff -u -p -r1.233 target.c
--- target.c	20 Nov 2009 17:23:38 -0000	1.233
+++ target.c	28 Nov 2009 16:57:39 -0000
@@ -481,8 +481,10 @@ void
 target_terminal_inferior (void)
 {
   /* A background resume (``run&'') should leave GDB in control of the
-     terminal.  */
-  if (target_is_async_p () && !sync_execution)
+     terminal. Use target_can_async_p, not target_is_async_p, since at
+     this point the target is not async yet.  However, if sync_execution
+     is not set, we know it will become async prior to resume.  */
+  if (target_can_async_p () && !sync_execution)
     return;
 
   /* If GDB is resuming the inferior in the foreground, install

      parent reply	other threads:[~2009-11-28 17:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-28 17:07 Vladimir Prus
     [not found] ` <20091128172915.GG18125@adacore.com>
2009-11-28 17:40   ` Vladimir Prus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200911282040.00504.vladimir@codesourcery.com \
    --to=vladimir@codesourcery.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox