From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1181 invoked by alias); 28 Nov 2009 17:40:12 -0000 Received: (qmail 1160 invoked by uid 22791); 28 Nov 2009 17:40:10 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 28 Nov 2009 17:40:04 +0000 Received: (qmail 11863 invoked from network); 28 Nov 2009 17:40:02 -0000 Received: from unknown (HELO wind.localnet) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 28 Nov 2009 17:40:02 -0000 From: Vladimir Prus To: Joel Brobecker , gdb-patches@sources.redhat.com Subject: Re: Fix async mode with remote targets Date: Sat, 28 Nov 2009 17:40:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.31-14-generic-pae; KDE/4.3.2; i686; ; ) References: <200911282007.49122.vladimir@codesourcery.com> <20091128172915.GG18125@adacore.com> In-Reply-To: <20091128172915.GG18125@adacore.com> MIME-Version: 1.0 Content-Type: Multipart/Mixed; boundary="Boundary-00=_wBWELqA7rJ8hBp5" Message-Id: <200911282040.00504.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00589.txt.bz2 --Boundary-00=_wBWELqA7rJ8hBp5 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Content-length: 114 On Saturday 28 November 2009 20:29:15 Joel Brobecker wrote: > ENOPATCH :) > > Sorry, here it goes. - Volodya --Boundary-00=_wBWELqA7rJ8hBp5 Content-Type: text/x-patch; charset="UTF-8"; name="final.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="final.diff" Content-length: 1369 Index: ChangeLog =================================================================== RCS file: /cvs/src/src/gdb/ChangeLog,v retrieving revision 1.11117 diff -u -p -r1.11117 ChangeLog --- ChangeLog 27 Nov 2009 16:11:56 -0000 1.11117 +++ ChangeLog 28 Nov 2009 16:57:39 -0000 @@ -1,3 +1,8 @@ +2009-11-28 Vladimir Prus + + * target.c (target_terminal_inferior): Use target_can_async_p, not + target_is_async_p. + 2009-11-27 Ulrich Weigand * s390-nat.c (s390_can_use_hw_breakpoint): Only support breakpoints Index: target.c =================================================================== RCS file: /cvs/src/src/gdb/target.c,v retrieving revision 1.233 diff -u -p -r1.233 target.c --- target.c 20 Nov 2009 17:23:38 -0000 1.233 +++ target.c 28 Nov 2009 16:57:39 -0000 @@ -481,8 +481,10 @@ void target_terminal_inferior (void) { /* A background resume (``run&'') should leave GDB in control of the - terminal. */ - if (target_is_async_p () && !sync_execution) + terminal. Use target_can_async_p, not target_is_async_p, since at + this point the target is not async yet. However, if sync_execution + is not set, we know it will become async prior to resume. */ + if (target_can_async_p () && !sync_execution) return; /* If GDB is resuming the inferior in the foreground, install --Boundary-00=_wBWELqA7rJ8hBp5--