From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: gdb-patches@sourceware.org
Subject: [patch] testsuite fuzzy results fixup: foll-fork.exp
Date: Thu, 26 Nov 2009 22:06:00 -0000 [thread overview]
Message-ID: <20091126220628.GA22204@host0.dyn.jankratochvil.net> (raw)
Hi,
one occasional timeout:
(gdb) PASS: gdb.base/foll-fork.exp: default show parent follow, no catchpoints
next 2
-callee: 9949
25 if (pid == 0) /* set breakpoint here */
-(gdb) PASS: gdb.base/foll-fork.exp: default parent follow, no catchpoints
+(gdb) callee: 18747
+FAIL: gdb.base/foll-fork.exp: (timeout) default parent follow, no catchpoints
Dropped the strings as there is no "callee" string expectation in
foll-fork.exp.
and with glibc-debuginfo installed one gets:
(gdb) break 39
Reading in symbols for ../nptl/sysdeps/unix/sysv/linux/fork.c...done.
Breakpoint 12 at 0x3ad22a4876: file ../nptl/sysdeps/unix/sysv/linux/fork.c, line 39.
(gdb) FAIL: gdb.base/foll-fork.exp: unpatch child, breakpoint at exit call
+
Breakpoint 12, __libc_fork () at ../nptl/sysdeps/unix/sysv/linux/fork.c:158
158 fresetlockfiles ();
(gdb) FAIL: gdb.base/foll-fork.exp: unpatch child, unpatched parent breakpoints from child (unknown output)
Thanks,
Jan
gdb/testsuite/
2009-11-26 Jan Kratochvil <jan.kratochvil@redhat.com>
* gdb.base/foll-fork.exp (unpatch child, breakpoint at exit call):
Force $srcfile file.
* gdb.base/foll-fork.c (callee): Comment out the printf call.
--- a/gdb/testsuite/gdb.base/foll-fork.c
+++ b/gdb/testsuite/gdb.base/foll-fork.c
@@ -9,7 +9,8 @@ void callee (i)
int i;
#endif
{
- printf("callee: %d\n", i);
+ /* Any output corrupts GDB CLI expect strings.
+ printf("callee: %d\n", i); */
}
#ifdef PROTOTYPES
--- a/gdb/testsuite/gdb.base/foll-fork.exp
+++ b/gdb/testsuite/gdb.base/foll-fork.exp
@@ -240,7 +240,8 @@ proc catch_fork_unpatch_child {} {
# Delete all breakpoints and catchpoints.
delete_breakpoints
- gdb_test "break $bp_exit" \
+ # Force $srcfile as the current GDB source can be in glibc sourcetree.
+ gdb_test "break $srcfile:$bp_exit" \
"Breakpoint .*file .*$srcfile, line .*" \
"unpatch child, breakpoint at exit call"
next reply other threads:[~2009-11-26 22:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-26 22:06 Jan Kratochvil [this message]
2009-11-30 20:37 ` Tom Tromey
2009-11-30 22:58 ` Jan Kratochvil
2009-12-21 5:55 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091126220628.GA22204@host0.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox