From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21057 invoked by alias); 26 Nov 2009 22:06:39 -0000 Received: (qmail 21043 invoked by uid 22791); 26 Nov 2009 22:06:38 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Nov 2009 22:06:33 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nAQM6VGr012142 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 26 Nov 2009 17:06:31 -0500 Received: from host0.dyn.jankratochvil.net (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nAQM6T2n031756 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 26 Nov 2009 17:06:31 -0500 Received: from host0.dyn.jankratochvil.net (localhost [127.0.0.1]) by host0.dyn.jankratochvil.net (8.14.3/8.14.3) with ESMTP id nAQM6TAU022243 for ; Thu, 26 Nov 2009 23:06:29 +0100 Received: (from jkratoch@localhost) by host0.dyn.jankratochvil.net (8.14.3/8.14.3/Submit) id nAQM6SM2022242 for gdb-patches@sourceware.org; Thu, 26 Nov 2009 23:06:28 +0100 Date: Thu, 26 Nov 2009 22:06:00 -0000 From: Jan Kratochvil To: gdb-patches@sourceware.org Subject: [patch] testsuite fuzzy results fixup: foll-fork.exp Message-ID: <20091126220628.GA22204@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.20 (2009-08-17) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00573.txt.bz2 Hi, one occasional timeout: (gdb) PASS: gdb.base/foll-fork.exp: default show parent follow, no catchpoints next 2 -callee: 9949 25 if (pid == 0) /* set breakpoint here */ -(gdb) PASS: gdb.base/foll-fork.exp: default parent follow, no catchpoints +(gdb) callee: 18747 +FAIL: gdb.base/foll-fork.exp: (timeout) default parent follow, no catchpoints Dropped the strings as there is no "callee" string expectation in foll-fork.exp. and with glibc-debuginfo installed one gets: (gdb) break 39 Reading in symbols for ../nptl/sysdeps/unix/sysv/linux/fork.c...done. Breakpoint 12 at 0x3ad22a4876: file ../nptl/sysdeps/unix/sysv/linux/fork.c, line 39. (gdb) FAIL: gdb.base/foll-fork.exp: unpatch child, breakpoint at exit call + Breakpoint 12, __libc_fork () at ../nptl/sysdeps/unix/sysv/linux/fork.c:158 158 fresetlockfiles (); (gdb) FAIL: gdb.base/foll-fork.exp: unpatch child, unpatched parent breakpoints from child (unknown output) Thanks, Jan gdb/testsuite/ 2009-11-26 Jan Kratochvil * gdb.base/foll-fork.exp (unpatch child, breakpoint at exit call): Force $srcfile file. * gdb.base/foll-fork.c (callee): Comment out the printf call. --- a/gdb/testsuite/gdb.base/foll-fork.c +++ b/gdb/testsuite/gdb.base/foll-fork.c @@ -9,7 +9,8 @@ void callee (i) int i; #endif { - printf("callee: %d\n", i); + /* Any output corrupts GDB CLI expect strings. + printf("callee: %d\n", i); */ } #ifdef PROTOTYPES --- a/gdb/testsuite/gdb.base/foll-fork.exp +++ b/gdb/testsuite/gdb.base/foll-fork.exp @@ -240,7 +240,8 @@ proc catch_fork_unpatch_child {} { # Delete all breakpoints and catchpoints. delete_breakpoints - gdb_test "break $bp_exit" \ + # Force $srcfile as the current GDB source can be in glibc sourcetree. + gdb_test "break $srcfile:$bp_exit" \ "Breakpoint .*file .*$srcfile, line .*" \ "unpatch child, breakpoint at exit call"