From: Joel Brobecker <brobecker@adacore.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Replace deprecated_memory_changed_hook with an observer.
Date: Wed, 25 Nov 2009 20:48:00 -0000 [thread overview]
Message-ID: <20091125204837.GH26004@adacore.com> (raw)
In-Reply-To: <8ac60eac0911251142r62f0e95al5ebd44503cac645c@mail.gmail.com>
> 2009-11-25 Paul Pluzhnikov <ppluzhnikov@google.com>
>
> * ada-lang.c (ada_value_assign): Use observer_notify_memory_changed.
> * valops.c (value_assign): Likewise.
> * defs.h (deprecated_memory_changed_hook): Remove.
> * interps.c (clear_interpreter_hooks): Adjust.
It looks like you forgot to remove the definition in top.c.
Pre-approved with that change.
> gdb/doc/ChangeLog:
>
> 2009-11-25 Paul Pluzhnikov <ppluzhnikov@google.com>
>
> * observer.texi: New memory_changed observer.
This part looks fine to me, but will have to wait for Eli's approval.
> gdb/gdbtk/ChangeLog:
>
> 2009-11-25 Paul Pluzhnikov <ppluzhnikov@google.com>
>
> * generic/gdbtk-hooks.c (gdbtk_memory_changed): Adjust.
> (gdbtk_add_hooks): Adjust.
This part is approved. Very kind of you to fix problems in gdbtk :).
--
Joel
next prev parent reply other threads:[~2009-11-25 20:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-25 19:42 Paul Pluzhnikov
2009-11-25 20:48 ` Joel Brobecker [this message]
2009-11-25 21:14 ` Paul Pluzhnikov
2009-12-02 17:38 ` [DOCO/PING] " Joel Brobecker
2009-12-02 18:00 ` Eli Zaretskii
2009-12-02 18:19 ` Joel Brobecker
2009-12-02 19:30 ` Paul Pluzhnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091125204837.GH26004@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=ppluzhnikov@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox