From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9533 invoked by alias); 25 Nov 2009 20:48:48 -0000 Received: (qmail 9518 invoked by uid 22791); 25 Nov 2009 20:48:48 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 25 Nov 2009 20:48:43 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 164652BAC4C; Wed, 25 Nov 2009 15:48:42 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 7GM5SHIqv7gD; Wed, 25 Nov 2009 15:48:42 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id CB4462BAC24; Wed, 25 Nov 2009 15:48:41 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 259A2F5905; Wed, 25 Nov 2009 15:48:37 -0500 (EST) Date: Wed, 25 Nov 2009 20:48:00 -0000 From: Joel Brobecker To: Paul Pluzhnikov Cc: gdb-patches@sourceware.org Subject: Re: [patch] Replace deprecated_memory_changed_hook with an observer. Message-ID: <20091125204837.GH26004@adacore.com> References: <8ac60eac0911251142r62f0e95al5ebd44503cac645c@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8ac60eac0911251142r62f0e95al5ebd44503cac645c@mail.gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00562.txt.bz2 > 2009-11-25 Paul Pluzhnikov > > * ada-lang.c (ada_value_assign): Use observer_notify_memory_changed. > * valops.c (value_assign): Likewise. > * defs.h (deprecated_memory_changed_hook): Remove. > * interps.c (clear_interpreter_hooks): Adjust. It looks like you forgot to remove the definition in top.c. Pre-approved with that change. > gdb/doc/ChangeLog: > > 2009-11-25 Paul Pluzhnikov > > * observer.texi: New memory_changed observer. This part looks fine to me, but will have to wait for Eli's approval. > gdb/gdbtk/ChangeLog: > > 2009-11-25 Paul Pluzhnikov > > * generic/gdbtk-hooks.c (gdbtk_memory_changed): Adjust. > (gdbtk_add_hooks): Adjust. This part is approved. Very kind of you to fix problems in gdbtk :). -- Joel