Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [commit] precord watchpoint tests
Date: Mon, 23 Nov 2009 22:25:00 -0000	[thread overview]
Message-ID: <20091123222543.GB5595@adacore.com> (raw)
In-Reply-To: <4B0AEBBB.6050904@vmware.com>

> +# FIXME 'set exec-dir' command should give some output so we can test.
> +gdb_test "set exec-direction forward" "" "set forward"

This is really a minor comment, so feel free to ignore. IMO, I don't
necessarily think that "set exec-dir" should produce some output
(that is not consistent with quite a few of our "set ..." commands),
particularly if the sole purpose of that output is to allow the
testsuite to verify that the command worked.  If testing is the only
point of output, then perhaps you should consider using gdb_test_multiple.
I am not 100% sure, but I think that this routine will allow you to test
that the command produced exactly no output.

It would be nice if we could just address the issue right now and be
done with it, rather than keeping duplicating FIXMEs like this.  Either
way - whether we decide to add some output or not, taking care of the
FIXME shouldn't be too time consuming... (assuming gdb_test_multiple
works as I think it does).

-- 
Joel


      reply	other threads:[~2009-11-23 22:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-23 20:12 Michael Snyder
2009-11-23 22:25 ` Joel Brobecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091123222543.GB5595@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox